Support long & short values for TIFF EXIF orientation tag. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mrghosti3
added a commit
to mrghosti3/cantaloupe
that referenced
this pull request
Mar 21, 2023
Thanks to original contributor Bastien Abadie <bastien@nextcairn.com> Original pr: cantaloupe-project#549 Changes are ported over to 'release/5.0' branch for fix cantaloupe-project#548
mrghosti3
added a commit
to mrghosti3/cantaloupe
that referenced
this pull request
Mar 21, 2023
Thanks to original contributor Bastien Abadie <bastien@nextcairn.com> Original pr: cantaloupe-project#549 Changes are ported over to 'release/5.0' branch for fix cantaloupe-project#548
janhoy
approved these changes
Apr 13, 2023
mrghosti3
added a commit
to mrghosti3/cantaloupe
that referenced
this pull request
Apr 13, 2023
Original pr: cantaloupe-project#549 Changes are ported over to 'release/5.0' branch for fix cantaloupe-project#548 Co-authored-by: mrghosti3 <mysteriousghst@gmail.com>
mrghosti3
added a commit
to mrghosti3/cantaloupe
that referenced
this pull request
Feb 16, 2024
Original pr: cantaloupe-project#549 Changes are ported over to 'release/5.0' branch for fix cantaloupe-project#548 Co-authored-by: mrghosti3 <mysteriousghst@gmail.com>
|
@La0 This seems really useful and we're interested in merging this. Are you still interested in contributing (sorry for the very long delay). Are you able to rebase this and fix the conflicts? Can you add a test? |
janhoy
added a commit
to janhoy/cantaloupe
that referenced
this pull request
Aug 9, 2024
|
Closing in favour of: #684 |
janhoy
added a commit
to janhoy/cantaloupe
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue #548 by inspecting the EXIF field's data type before converting it to
Orientation.I added a
getFieldmethod in theDirectoryclass to be able to retrieve theFieldand itsDataTypeinstance.