Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-commit configuration and steps #341

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akcano
Copy link
Contributor

@akcano akcano commented Feb 18, 2025

No description provided.

@akcano akcano requested a review from SecondSkoll February 18, 2025 15:56
@akcano akcano self-assigned this Feb 18, 2025
Copy link
Collaborator

@SecondSkoll SecondSkoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move the pre-commit config file to the .sphinx directory? It can be installed from any location within a git repository.

You also don't need to add pre-commit to requirements, as requirements is used by the VENV which is spun up on actions being performed. A user will need pre-commit in their environment when they use their IDE or trigger git commits.

@akcano akcano force-pushed the feature/pre-commit branch from d9ea2d1 to db5e019 Compare February 21, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants