Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Centralize Status Management #89

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Mar 13, 2024

Description

This PR uses new ops feature CollectStatus Event to manage status Charm. Event named collect_unit_status sets the status of charm automatically at the end of every hook.

Reference:

https://ops.readthedocs.io/en/latest/#ops.CollectStatusEvent
https://discourse.charmhub.io/t/how-to-set-a-charms-status/11771

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner March 13, 2024 13:27
src/charm.py Outdated Show resolved Hide resolved
@gatici gatici marked this pull request as draft March 13, 2024 15:17
@gatici gatici force-pushed the TELCO-1039-Cetralize-status-management branch from a82af4a to f61839d Compare March 14, 2024 08:49
@gatici gatici marked this pull request as ready for review March 14, 2024 08:50
@gatici gatici force-pushed the TELCO-1039-Cetralize-status-management branch from f61839d to e9a7bf9 Compare March 14, 2024 11:03
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici force-pushed the TELCO-1039-Cetralize-status-management branch from e9a7bf9 to 8f0b729 Compare March 14, 2024 12:07
@gatici gatici merged commit 2884067 into main Mar 14, 2024
10 checks passed
@gatici gatici deleted the TELCO-1039-Cetralize-status-management branch March 14, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants