Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement log forwarding #77

Merged
merged 3 commits into from
Mar 1, 2024
Merged

feat: implement log forwarding #77

merged 3 commits into from
Mar 1, 2024

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Mar 1, 2024

Description

Implement log forwarding via Pebble's new log-target spec. We use the loki_push_api charm relation to get the loki endpoint.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gruyaume gruyaume requested a review from a team as a code owner March 1, 2024 20:54
@gruyaume gruyaume merged commit 4fd11f0 into main Mar 1, 2024
10 checks passed
@gruyaume gruyaume deleted the dev-logs branch March 1, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbeierl markbeierl markbeierl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruyaume @markbeierl