Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use build-packages #64

Merged
merged 2 commits into from
Feb 26, 2024
Merged

chore: use build-packages #64

merged 2 commits into from
Feb 26, 2024

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Feb 23, 2024 •
edited
Loading

Description

Use build-packages and install Python packages using requirements file instead of leveraging pre-built binaries. This avoids surprises and inconsistencies from the dev environment.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gruyaume gruyaume requested a review from a team as a code owner February 23, 2024 20:18
@gruyaume gruyaume merged commit b1cbb03 into main Feb 26, 2024
10 checks passed
@gruyaume gruyaume deleted the dev-build branch February 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruyaume @gatici