Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing the fiveg_nrf endpoint name and pinning Juju version to 3.3.0.0 #59

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Feb 14, 2024

Description

  • fiveg_nrf endpoint name was different than the one in the metadata.yaml. This PR puts the correct name.
  • Pinning juju version to 3.3.0.0, which is last working. With 3.3.1.0 tests started failing because of
 File "/home/ubuntu/github-runner/_work/sdcore-tests/sdcore-tests/.tox/integration/lib/python3.10/site-packages/juju/version.py", line 19, in <module>
    CLIENT_VERSION = re.search(r'\d+\.\d+\.\d+', open(VERSION_FILE_PATH).read().strip()).group()
FileNotFoundError: [Errno 2] No such file or directory: '/home/ubuntu/github-runner/_work/sdcore-tests/sdcore-tests/.tox/integration/lib/python3.10/site-packages/VERSION'

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici requested a review from a team as a code owner February 14, 2024 09:10
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici changed the title fix: Fixing the fiveg_nrf endpoint name fix: Fixing the fiveg_nrf endpoint name and pinning Juju version to latest working Feb 14, 2024
@gatici gatici changed the title fix: Fixing the fiveg_nrf endpoint name and pinning Juju version to latest working fix: Fixing the fiveg_nrf endpoint name and pinning Juju version to 3.3.0.0 Feb 14, 2024
@gatici gatici merged commit 571ff88 into main Feb 14, 2024
13 checks passed
@gatici gatici deleted the TELCO-952-fix-fiveg_nrf_endpoint branch February 14, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants