Skip to content

Commit

Permalink
fix: use ubuntu@24.04 in TF modules (#392)
Browse files Browse the repository at this point in the history
  • Loading branch information
patriciareinoso authored Dec 18, 2024
1 parent 4567d39 commit a817607
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ resource "juju_application" "pcf" {
name = "sdcore-pcf-k8s"
channel = var.channel
revision = var.revision
base = var.base
}

config = var.config
Expand Down
6 changes: 6 additions & 0 deletions terraform/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ variable "revision" {
default = null
}

variable "base" {
description = "The operating system on which to deploy"
type = string
default = "ubuntu@24.04"
}

variable "units" {
description = "Number of units to deploy"
type = number
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
TLS_CHARM_CHANNEL = "latest/stable"
GRAFANA_AGENT_CHARM_NAME = "grafana-agent-k8s"
GRAFANA_AGENT_CHARM_CHANNEL = "latest/stable"
SDCORE_CHARMS_SERIES = "noble"


@pytest.fixture(scope="module")
Expand Down Expand Up @@ -154,6 +155,7 @@ async def _deploy_nms(ops_test: OpsTest):
NMS_CHARM_NAME,
application_name=NMS_CHARM_NAME,
channel=NMS_CHARM_CHANNEL,
series=SDCORE_CHARMS_SERIES, # TODO: This should be replaced with base="ubuntu@24.04" once it's properly supported # noqa: E501
)
await ops_test.model.integrate(
relation1=f"{NMS_CHARM_NAME}:common_database", relation2=DATABASE_CHARM_NAME
Expand All @@ -173,6 +175,7 @@ async def _deploy_nrf(ops_test: OpsTest):
NRF_CHARM_NAME,
application_name=NRF_CHARM_NAME,
channel=NRF_CHARM_CHANNEL,
series=SDCORE_CHARMS_SERIES, # TODO: This should be replaced with base="ubuntu@24.04" once it's properly supported # noqa: E501
trust=True,
)
await ops_test.model.integrate(relation1=NRF_CHARM_NAME, relation2=DATABASE_CHARM_NAME)
Expand Down

0 comments on commit a817607

Please sign in to comment.