-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression from #71. #74
Merged
chanchiwai-ray
merged 4 commits into
canonical:main
from
chanchiwai-ray:bug/regression-71
Apr 29, 2024
Merged
Fix regression from #71. #74
chanchiwai-ray
merged 4 commits into
canonical:main
from
chanchiwai-ray:bug/regression-71
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the "Health" key to a string of "NA" when it's not present.
chanchiwai-ray
requested review from
Pjack,
aieri,
samuelallan72,
jneo8 and
gabrielcocenza
April 29, 2024 01:28
Can you add a unit test covering the scenario where "Health" is not present? |
jneo8
approved these changes
Apr 29, 2024
sudeephb
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
sudeephb
approved these changes
Apr 29, 2024
dashmage
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny nit on the comment, LGTM!
Co-authored-by: Ashley James <ashleyjames2800@gmail.com>
chanchiwai-ray
force-pushed
the
bug/regression-71
branch
from
April 29, 2024 05:32
d2073f1
to
33fb1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the "Health" key to a string of "NA" when it's falsy (e.g.
None
, "").Note:
If "Health" is
None
, it can cause the following error: