Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle different storage controller responses #57

Closed
sdemircan opened this issue Dec 5, 2023 · 2 comments · Fixed by #71
Closed

Handle different storage controller responses #57

sdemircan opened this issue Dec 5, 2023 · 2 comments · Fixed by #71
Labels
bug Something isn't working

Comments

@sdemircan
Copy link
Contributor

While checking storage controller data in get_storage_controller_data function API response varies between different ILO versions and different vendors(ie. Inspur).
sdemircan added a commit to sdemircan/prometheus-hardware-exporter that referenced this issue Dec 5, 2023
@sdemircan
handle different storage controller responses canonical#57
3bd80a3
@Pjack Pjack added the enhancement New feature or request label Dec 5, 2023
@Pjack Pjack added bug Something isn't working and removed enhancement New feature or request labels Apr 18, 2024
@Pjack
Copy link

Pjack commented Apr 18, 2024

Could you share additional details or specifications about the requirements? This will help us understand how best to assist you.

chanchiwai-ray pushed a commit to chanchiwai-ray/prometheus-hardware-exporter that referenced this issue Apr 24, 2024
@sdemircan @chanchiwai-ray
handle different storage controller responses canonical#57
2bb8fc1
chanchiwai-ray added a commit that referenced this issue Apr 25, 2024
@chanchiwai-ray @sdemircan
Handle different response in storage data for redfish api (#71)
5f33417 
* Remove unused attributes.

* Reorder logic in `_verify_redfish_call`.

* Handle different storage controller responses #57

* Add unit tests for both type of storage controller responses

---------

Co-authored-by: Serhat Rıfat Demircan <demircan.serhat@gmail.com>
@Pjack
Copy link

Pjack commented May 2, 2024

Since #71 is been merged. The scope should cover this one. Welcome to reopen it or submit new PR if we miss anything. thanks

@Pjack Pjack closed this as completed May 2, 2024
@Pjack Pjack linked a pull request May 2, 2024 that will close this issue
Handle different response in storage data for redfish api #71
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@sdemircan @Pjack