-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run func tests locally on runner #129
Merged
Merged
+123
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dependency on the external juju controller, switching to running them locally on a larger github runner instance. In the process, update to the latest template from our automation.
So disable it for now to move forward.
an attempt to reduce the bundle size, and avoid cases where storage is required (makes it simpler on an lxd cloud)
This may be causing the snap down test to fail, because the default status hook interval is 5 minutes. Previously, we had configured the interval to be 30s, and the status update timeout in the tests is only 2 minutes. There is the risk that this much shorter interval will increase the load on the VM too much because of all the extra processing.
chanchiwai-ray
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Thanks
Pjack
approved these changes
Feb 14, 2025
jneo8
approved these changes
Feb 14, 2025
samuelallan72
added a commit
to canonical/solutions-engineering-automation
that referenced
this pull request
Feb 14, 2025
Since canonical/openstack-exporter-operator#129 followed the latest template, we can now add it to automation.
Awesome! Thanks for changing this |
gabrielcocenza
pushed a commit
to canonical/solutions-engineering-automation
that referenced
this pull request
Feb 14, 2025
Since canonical/openstack-exporter-operator#129 followed the latest template, we can now add it to automation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on the external juju controller, switching to running them locally on a larger github runner instance. In the process, update to the latest template from our automation.
Note that I removed cinder and ceph from the func test bundle. These services are not used in the func tests, and they take up a lot of compute and storage resources because they need to run in VMs. I think removing these, plus the new larger github runners available, has enabled the tests to pass without needing to deploy on an external juju controller.