Add extra checks for DeploymentDescription existence
#548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the cluster is not yet ready and the description not yet available, set password action throws an exception. This PR improves the password action check for the cluster's current role. If the cluster description is not yet ready, we return a failed event instead.
phvalguima
changed the title
DeploymentDescription existence
phvalguima
changed the title
DeploymentDescription existenceDeploymentDescription existence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the cluster is not yet ready and the description not yet available, set password action throws an exception.
This PR reviews the base charm calls to the
.deployment_desc()function and ensures we have appropriate checks each time.Relates to: #547