Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update controller and web-app to 1.10.0-rc.0 #432

Closed
wants to merge 2 commits into from

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Feb 22, 2025

This commit updates the charms in this repository to the 1.10.0-rc.0 version, which includes:

  • Using upstream's latest 1.10.0-rc.0 image for both charms
  • Updating the list of images for Jupyter, Rstudio and VSCode from the dropdown menu
  • Adding a METRICS environment variable to the web-app charm to match upstream

See kubeflow/manifests#2995 for reference on the changes.

This commit updates the charms in this repository to the 1.10.0-rc.0 version,
which includes:
* Using upstream's latest 1.10.0-rc.0 image for both charms
* Updating the list of images for Jupyter, Rstudio and VSCode from the dropdown menu
* Adding a METRICS environment variable to the web-app charm to match upstream
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should we use kf/kf rc.1? (left a comment about why we should do it).
  • What about the following change:
348,351c349,354
>           - limitsKey: "habana.ai/gaudi"
>             uiName: "Intel Gaudi"
380c383

Comment on lines +28 to +33
- kubeflownotebookswg/jupyter-scipy:v1.10.0-rc.0
- kubeflownotebookswg/jupyter-pytorch-full:v1.10.0-rc.0
- kubeflownotebookswg/jupyter-pytorch-cuda-full:v1.10.0-rc.0
- kubeflownotebookswg/jupyter-pytorch-gaudi-full:v1.10.0-rc.0
- kubeflownotebookswg/jupyter-tensorflow-full:v1.10.0-rc.0
- kubeflownotebookswg/jupyter-tensorflow-cuda-full:v1.10.0-rc.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since those images aren't published (docker pull fails), should we go straight to kf/kf rc.1 now that it's published?

@@ -169,6 +169,7 @@ def _get_env_vars(self):
"UI": config["ui"],
"USERID_HEADER": "kubeflow-userid",
"USERID_PREFIX": "",
"METRICS": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of just enabling metrics like that, we should enable this in a separate feature PR alongside a dashboard and metrics. This change should be identical to what we did for kubeflow-volumes in canonical/kubeflow-volumes-operator#176. In that case we also used a dev branch, but this is probably redundant since we 're not breaking something.

@DnPlas
Copy link
Contributor Author

DnPlas commented Feb 25, 2025

  • Should we use kf/kf rc.1? (left a comment about why we should do it).

    • What about the following change:
348,351c349,354
>           - limitsKey: "habana.ai/gaudi"
>             uiName: "Intel Gaudi"
380c383

Good catch! The change was added in 1.9.1, hence the miss. I'll add it as part of this PR.

@DnPlas
Copy link
Contributor Author

DnPlas commented Feb 25, 2025

Closing in favour of #434.

The discussion about the METRICS env variable will be held offline as there are a couple things to check.

@DnPlas DnPlas closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants