External harness #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrutlucian94
force-pushed
the
external_harness
branch
2 times, most recently
from
8614755 to
f32d7c8
Compare
Closed
petrutlucian94
force-pushed
the
external_harness
branch
from
5cb5540 to
2456b8d
Compare
The rock tests are expected to share as significant amount of code (e.g. k8s harness, various helpers), which was moved to a separate project to avoid duplication. While at it, we're fixing the linter and code formatter jobs.
We'll ensure that the integration tests fail early if the rock images are not specified.
petrutlucian94
force-pushed
the
external_harness
branch
from
2456b8d to
81abcb6
Compare
berkayoz
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Great work, should we adjust to use the metas directly introduced in k8s-test-harness#5 instead of the env variables?
Sure, but I'd rather do it in a separate PR if that's ok with you. I'd use these helpers as well as soon as they merge: |
petrutlucian94
pushed a commit
to petrutlucian94/multus-rock
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to external harness
The rock tests are expected to share as significant amount of code
(e.g. k8s harness, various helpers), which was moved to a separate
project to avoid duplication.
While at it, we're fixing the linter and code formatter jobs.