Skip to content

Commit

Permalink
fix: lint and format
Browse files Browse the repository at this point in the history
  • Loading branch information
NohaIhab committed Jan 24, 2024
1 parent c01a54f commit c3a869d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
18 changes: 9 additions & 9 deletions src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@
# See LICENSE file for licensing details.
#

import json
import logging
from pathlib import Path

import botocore.exceptions
import yaml
from charmed_kubeflow_chisme.exceptions import ErrorWithStatus
from charms.data_platform_libs.v0.data_interfaces import DatabaseRequires
from charms.grafana_k8s.v0.grafana_dashboard import GrafanaDashboardProvider
Expand All @@ -18,7 +16,10 @@
)
from charms.observability_libs.v1.kubernetes_service_patch import KubernetesServicePatch
from charms.prometheus_k8s.v0.prometheus_scrape import MetricsEndpointProvider
from charms.resource_dispatcher.v0.kubernetes_manifests import KubernetesManifestRequirerWrapper, KubernetesManifest
from charms.resource_dispatcher.v0.kubernetes_manifests import (
KubernetesManifest,
KubernetesManifestRequirerWrapper,
)
from jinja2 import Template
from lightkube.models.core_v1 import ServicePort
from ops.charm import CharmBase
Expand Down Expand Up @@ -59,12 +60,10 @@ def __init__(self, *args):
)

self._secrets_manifests_wrapper = KubernetesManifestRequirerWrapper(
charm = self,
relation_name = "secrets"
charm=self, relation_name="secrets"
)
self._poddefaults_manifests_wrapper = KubernetesManifestRequirerWrapper(
charm = self,
relation_name = "pod-defaults"
charm=self, relation_name="pod-defaults"
)

self.framework.observe(self.on.upgrade_charm, self._on_event)
Expand Down Expand Up @@ -399,12 +398,13 @@ def _on_database_relation_removed(self, _) -> None:
"""Event is fired when relation with postgres is broken."""
self.unit.status = BlockedStatus("Please add relation to the database")

def _send_manifests(self, context, manifest_files, relation_requirer: KubernetesManifestRequirerWrapper):
def _send_manifests(
self, context, manifest_files, relation_requirer: KubernetesManifestRequirerWrapper
):
"""Send manifests from folder to desired relation."""
manifests = self._create_manifests(manifest_files, context)
relation_requirer.send_data(manifests)


def _create_manifests(self, manifest_files, context):
"""Create manifests string for given folder and context."""
manifests = []
Expand Down
4 changes: 3 additions & 1 deletion tests/unit/test_operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,9 @@ def test_create_manifests(self, harness: Harness):
)
@patch("charm.MlflowCharm._create_manifests")
@patch("charm.MlflowCharm.secrets_manifests_wrapper")
def test_send_manifests(self, secrets_manifests_wrapper:MagicMock, create_manifests: MagicMock, harness: Harness):
def test_send_manifests(
self, secrets_manifests_wrapper: MagicMock, create_manifests: MagicMock, harness: Harness
):
tmp_manifests = "[]"
create_manifests.return_value = tmp_manifests
secrets_manifests_wrapper = MagicMock()
Expand Down

0 comments on commit c3a869d

Please sign in to comment.