Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(images): Implement design for image download form MAASENG-4362 #5616

Conversation

abuyukyi101198
Copy link
Contributor

@abuyukyi101198 abuyukyi101198 commented Feb 20, 2025

Done

  • Renamed DownloadImages, DeleteImages and DeleteImageConfirm to SelectUpstreamImagesForm, DeleteMultipleImagesForm and DeleteImageForm
  • Moved aforementioned forms under ImagesForms
  • Fixed wording in SelectUpstreamImagesForm
  • Fixed styling in SelectUpstreamImagesForm
  • Added accordion grouping to SelectUpstreamImagesForm distros

QA steps

  • Verify SelectUpstreamImagesForm matches the design
  • Ensure image download works as it did before

Fixes

Resolves:

MAASENG-4362

Screenshots

Screenshot 2025-02-20 at 17 52 12 Screenshot 2025-02-20 at 17 52 27 Screenshot 2025-02-20 at 17 52 34

@webteam-app
Copy link

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a really nice change

@abuyukyi101198 abuyukyi101198 merged commit b883857 into canonical:main Feb 21, 2025
8 checks passed
@abuyukyi101198 abuyukyi101198 deleted the feat-implement-image-download-design-MAASENG-4362 branch February 21, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants