Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update centraldashboard 1.9.0 -> 1.10.0-rc.0 #249

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Feb 22, 2025

This commit changes the oci-image from the team's maintained rock to upstream's latest centraldashboard container image (v1.10.0-rc.0). It also changes the workload service to use tini as per indicated in the code comments.

These changes are based on the latest sync of the kubeflow/kubeflow to the kubeflow/manifests repository. See kubeflow/manifests#2995 for reference.

This commit changes the oci-image from the team's maintained rock to
upstream's latest centraldashboard container image (v1.10.0-rc.0).
It also adds a new environment variable (COLLECT_METRICS), and changes
the workload service to use tini as per indicated in the code comments.
mvlassis
mvlassis previously approved these changes Feb 25, 2025
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DnPlas
Copy link
Contributor Author

DnPlas commented Feb 25, 2025

I removed the COLLECT_METRICS env variable from the pebble layer as enabling it and integrating with COS will be handled in a different effort. @mvlassis need a re-approval.

@DnPlas DnPlas merged commit 4843f7c into main Feb 25, 2025
10 checks passed
@DnPlas DnPlas deleted the KF-6864-dashboard-1.10.0-rc.0 branch February 25, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants