Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartAuthSession allows insecure parameter encryption #11

Open
ansiwen opened this issue Feb 13, 2023 · 0 comments
Open

StartAuthSession allows insecure parameter encryption #11

ansiwen opened this issue Feb 13, 2023 · 0 comments

Comments

@ansiwen
Copy link

ansiwen commented Feb 13, 2023

The StartAuthSession method allows to set the symmetric parameter and therefore enable parameter encryption, even if tpmKey and bind are nil (or the bind object has no authValue set). But in these cases the session key is empty, which means the encryption key for the parameter encryption is quasi-public, because all data to calculate the encryption key has been transferred in clear text. If there are no valid use-cases, I would recommend to fail, when symmetric is set, but the session key is empty.

(I would have used symmetric with both tpmKey and bind set to nil, and falsely assumed it's using an ephemeral but secure encryption key then. I only noticed my mistake, because I wanted to know how the ephemeral key exchange exactly works.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant