Fail release-libraries action if the lib has libpatch greater than expected version

release-libraries/action.yaml

@@ -21,6 +21,11 @@ inputs:
     required: true
     description: |
       Github Token needed for automatic tagging when publishing
+  fail-build:
+    required: false
+    default: true
+    description: >
+      Whether to fail the entire build if publishing lib fails for any reason.
 runs:
   using: node20
   main: ../dist/release-libraries/index.js

src/services/charmcraft/charmcraft.test.ts

@@ -845,4 +845,52 @@ describe('the charmcraft service', () => {
       );
     });
   });
+
+  describe('test publishing libs', () => {
+    describe('with a correct version', () => {
+      it('should succeed without a failure', async () => {
+        const charmcraft = new Charmcraft('token');
+
+        mockExec.mockResolvedValue({
+          exitCode: 0,
+          stderr: '',
+          stdout:
+            'Library charms.test.v0.lib sent to the store with version 0.2',
+        });
+
+        const response = await charmcraft.publishLib('test', 'v0', 'lib');
+        expect(response).toBeTruthy();
+
+        expect(mockExec).toHaveBeenCalled();
+        expect(mockExec).toHaveBeenCalledWith(
+          'charmcraft',
+          ['publish-lib', 'charms.test.v0.lib'],
+          expect.anything(),
+        );
+      });
+    });
+
+    describe('with an incorrect version', () => {
+      it('should return a failure', async () => {
+        const charmcraft = new Charmcraft('token');
+
+        mockExec.mockResolvedValue({
+          exitCode: 0,
+          stderr: '',
+          stdout:
+            "Library charms.test.v0.lib has a wrong LIBPATCH number, it's too high and needs to be consecutive Charmhub highest version is 0.1.",
+        });
+
+        const response = await charmcraft.publishLib('test', 'v0', 'lib');
+        expect(response).toBeFalsy();
+
+        expect(mockExec).toHaveBeenCalled();
+        expect(mockExec).toHaveBeenCalledWith(
+          'charmcraft',
+          ['publish-lib', 'charms.test.v0.lib'],
+          expect.anything(),
+        );
+      });
+    });
+  });
 });

src/services/charmcraft/charmcraft.ts

@@ -422,12 +422,19 @@ class Charmcraft {
   async publishLib(charm: string, majorVersion: string, libName: string) {
     const args = ['publish-lib', `charms.${charm}.${majorVersion}.${libName}`];
     debug(`about to publish lib with ${args}`);
-    await exec('charmcraft', args, this.execOptions).catch((reason: any) => {
-      const msg: string = `charmcraft ${args} ${this.execOptions} failed with ${reason}`;
-      debug(msg);
-      core.setFailed(msg);
+    const { exitCode, stdout, stderr } = await getExecOutput(
+      'charmcraft',
+      args,
+      this.execOptions,
+    );
+    if (exitCode !== 0 || stdout.indexOf('has a wrong LIBPATCH number') > 0) {
+      if (exitCode !== 0) {
+        core.setFailed(stderr);
+      } else {
+        core.setFailed(stdout);
+      }
       return false;
-    });
+    }
     return true;
   }
 }