Fail release-libraries action if the lib has libpatch greater than expected version #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simskij
requested changes
May 8, 2024
carlcsaposs-canonical
referenced
this pull request
in canonical/mysql-router-operator
Jun 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [canonical/charming-actions](https://togithub.com/canonical/charming-actions) | action | minor | `2.2.2` -> `2.6.0` | --- ### Release Notes <details> <summary>canonical/charming-actions (canonical/charming-actions)</summary> ### [`v2.6.0`](https://togithub.com/canonical/charming-actions/releases/tag/2.6.0) [Compare Source](https://togithub.com/canonical/charming-actions/compare/2.4.0...2.6.0) ##### What's Changed - bump deps and address vuln issues by [@​simskij](https://togithub.com/simskij) in [https://github.com/canonical/charming-actions/pull/110](https://togithub.com/canonical/charming-actions/pull/110) - chore(deps): pin dependencies by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/111](https://togithub.com/canonical/charming-actions/pull/111) - fix(renovate): Update patch (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/112](https://togithub.com/canonical/charming-actions/pull/112) - fix(renovate): Update actions/checkout action to v3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/115](https://togithub.com/canonical/charming-actions/pull/115) - fail channel action if branch name is invalid by [@​simskij](https://togithub.com/simskij) in [https://github.com/canonical/charming-actions/pull/105](https://togithub.com/canonical/charming-actions/pull/105) - fix(renovate): Update github-actions to v4 (major) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/117](https://togithub.com/canonical/charming-actions/pull/117) - fix(renovate): Update major (major) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/118](https://togithub.com/canonical/charming-actions/pull/118) - fix(renovate): Update dependency dayjs to ^1.11.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/120](https://togithub.com/canonical/charming-actions/pull/120) - fix(renovate): Update dependency typescript to v5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/116](https://togithub.com/canonical/charming-actions/pull/116) - fix(renovate): Update minor (minor) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/114](https://togithub.com/canonical/charming-actions/pull/114) - ci: run npm build during CI to ensure no failures by [@​jnsgruk](https://togithub.com/jnsgruk) in [https://github.com/canonical/charming-actions/pull/121](https://togithub.com/canonical/charming-actions/pull/121) - fix(renovate): Update patch to ^6.13.2 (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/122](https://togithub.com/canonical/charming-actions/pull/122) - fix(renovate): Update patch (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/123](https://togithub.com/canonical/charming-actions/pull/123) - read metadata from charmcraft.yaml by [@​addyess](https://togithub.com/addyess) in [https://github.com/canonical/charming-actions/pull/132](https://togithub.com/canonical/charming-actions/pull/132) - Support uploading multiple charm files by [@​sudeephb](https://togithub.com/sudeephb) in [https://github.com/canonical/charming-actions/pull/131](https://togithub.com/canonical/charming-actions/pull/131) - chore(style): Use same style on fields by [@​merkata](https://togithub.com/merkata) in [https://github.com/canonical/charming-actions/pull/126](https://togithub.com/canonical/charming-actions/pull/126) - docs(README): Add missing inputs by [@​merkata](https://togithub.com/merkata) in [https://github.com/canonical/charming-actions/pull/125](https://togithub.com/canonical/charming-actions/pull/125) - Add "dump-logs" action by [@​sed-i](https://togithub.com/sed-i) in [https://github.com/canonical/charming-actions/pull/133](https://togithub.com/canonical/charming-actions/pull/133) - make github tag in upload-charm optional by [@​lucabello](https://togithub.com/lucabello) in [https://github.com/canonical/charming-actions/pull/137](https://togithub.com/canonical/charming-actions/pull/137) - Update README.md by [@​cbartz](https://togithub.com/cbartz) in [https://github.com/canonical/charming-actions/pull/136](https://togithub.com/canonical/charming-actions/pull/136) - fix(renovate): Update actions/upload-artifact action to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/134](https://togithub.com/canonical/charming-actions/pull/134) - fix(renovate): Update patch (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/127](https://togithub.com/canonical/charming-actions/pull/127) - Fail release-libraries action if the lib has libpatch greater than expected version by [@​shayancanonical](https://togithub.com/shayancanonical) in [https://github.com/canonical/charming-actions/pull/135](https://togithub.com/canonical/charming-actions/pull/135) - add promote action by [@​lucabello](https://togithub.com/lucabello) in [https://github.com/canonical/charming-actions/pull/138](https://togithub.com/canonical/charming-actions/pull/138) - fix: promote-charm action entrypoint by [@​lucabello](https://togithub.com/lucabello) in [https://github.com/canonical/charming-actions/pull/145](https://togithub.com/canonical/charming-actions/pull/145) ##### New Contributors - [@​renovate](https://togithub.com/renovate) made their first contribution in [https://github.com/canonical/charming-actions/pull/111](https://togithub.com/canonical/charming-actions/pull/111) - [@​addyess](https://togithub.com/addyess) made their first contribution in [https://github.com/canonical/charming-actions/pull/132](https://togithub.com/canonical/charming-actions/pull/132) - [@​sudeephb](https://togithub.com/sudeephb) made their first contribution in [https://github.com/canonical/charming-actions/pull/131](https://togithub.com/canonical/charming-actions/pull/131) - [@​sed-i](https://togithub.com/sed-i) made their first contribution in [https://github.com/canonical/charming-actions/pull/133](https://togithub.com/canonical/charming-actions/pull/133) - [@​cbartz](https://togithub.com/cbartz) made their first contribution in [https://github.com/canonical/charming-actions/pull/136](https://togithub.com/canonical/charming-actions/pull/136) - [@​shayancanonical](https://togithub.com/shayancanonical) made their first contribution in [https://github.com/canonical/charming-actions/pull/135](https://togithub.com/canonical/charming-actions/pull/135) **Full Changelog**: canonical/charming-actions@2.4.0...2.6.0 ### [`v2.4.0`](https://togithub.com/canonical/charming-actions/releases/tag/2.4.0) [Compare Source](https://togithub.com/canonical/charming-actions/compare/2.3.0...2.4.0) ##### What's Changed - update to node16 for deprecation warnings by [@​lucabello](https://togithub.com/lucabello) in [https://github.com/canonical/charming-actions/pull/95](https://togithub.com/canonical/charming-actions/pull/95) - Add pull image option by [@​kian99](https://togithub.com/kian99) in [https://github.com/canonical/charming-actions/pull/102](https://togithub.com/canonical/charming-actions/pull/102) ##### New Contributors - [@​lucabello](https://togithub.com/lucabello) made their first contribution in [https://github.com/canonical/charming-actions/pull/95](https://togithub.com/canonical/charming-actions/pull/95) - [@​kian99](https://togithub.com/kian99) made their first contribution in [https://github.com/canonical/charming-actions/pull/102](https://togithub.com/canonical/charming-actions/pull/102) **Full Changelog**: canonical/charming-actions@2.3.0...2.4.0 ### [`v2.3.0`](https://togithub.com/canonical/charming-actions/releases/tag/2.3.0) [Compare Source](https://togithub.com/canonical/charming-actions/compare/2.2.5...2.3.0) #### What's Changed - Update README.md by [@​beliaev-maksim](https://togithub.com/beliaev-maksim) in [https://github.com/canonical/charming-actions/pull/94](https://togithub.com/canonical/charming-actions/pull/94) - Adds support for pre-built charms in the `upload-charm` action by [@​gruyaume](https://togithub.com/gruyaume) in [https://github.com/canonical/charming-actions/pull/96](https://togithub.com/canonical/charming-actions/pull/96) #### New Contributors - [@​gruyaume](https://togithub.com/gruyaume) made their first contribution in [https://github.com/canonical/charming-actions/pull/96](https://togithub.com/canonical/charming-actions/pull/96) **Full Changelog**: canonical/charming-actions@2.2.5...2.3.0 ### [`v2.2.5`](https://togithub.com/canonical/charming-actions/releases/tag/2.2.5) [Compare Source](https://togithub.com/canonical/charming-actions/compare/2.2.4...2.2.5) #### What's Changed - remove clean up of channel signs, reverting [#​91](https://togithub.com/canonical/charming-actions/issues/91) by [@​beliaev-maksim](https://togithub.com/beliaev-maksim) in [https://github.com/canonical/charming-actions/pull/93](https://togithub.com/canonical/charming-actions/pull/93) **Full Changelog**: canonical/charming-actions@2.2.4...2.2.5 ### [`v2.2.4`](https://togithub.com/canonical/charming-actions/releases/tag/2.2.4) [Compare Source](https://togithub.com/canonical/charming-actions/compare/2.2.3...2.2.4) #### What's Changed This version changes the default publish branch on charmhub to `<track-name>/edge/pr-<pr number>`. For more see [README.md](https://togithub.com/canonical/charming-actions/blob/main/channel/README.md#branch-selection) - clean channel for charmcraft publish from disallowed signs by [@​beliaev-maksim](https://togithub.com/beliaev-maksim) in [https://github.com/canonical/charming-actions/pull/91](https://togithub.com/canonical/charming-actions/pull/91) - update channel for feature branches by [@​beliaev-maksim](https://togithub.com/beliaev-maksim) in [https://github.com/canonical/charming-actions/pull/92](https://togithub.com/canonical/charming-actions/pull/92) #### New Contributors - [@​beliaev-maksim](https://togithub.com/beliaev-maksim) made their first contribution in [https://github.com/canonical/charming-actions/pull/91](https://togithub.com/canonical/charming-actions/pull/91) **Full Changelog**: canonical/charming-actions@2.2.3...2.2.4 ### [`v2.2.3`](https://togithub.com/canonical/charming-actions/releases/tag/2.2.3) [Compare Source](https://togithub.com/canonical/charming-actions/compare/2.2.2...2.2.3) #### What's Changed - Fix destructive-mode option in README by [@​taurus-forever](https://togithub.com/taurus-forever) in [https://github.com/canonical/charming-actions/pull/87](https://togithub.com/canonical/charming-actions/pull/87) - build: use node16 for `check-libraries` by [@​jnsgruk](https://togithub.com/jnsgruk) in [https://github.com/canonical/charming-actions/pull/89](https://togithub.com/canonical/charming-actions/pull/89) #### New Contributors - [@​taurus-forever](https://togithub.com/taurus-forever) made their first contribution in [https://github.com/canonical/charming-actions/pull/87](https://togithub.com/canonical/charming-actions/pull/87) **Full Changelog**: canonical/charming-actions@2.2.2...2.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 3am every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/mysql-router-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
carlcsaposs-canonical
referenced
this pull request
in canonical/mysql-router-k8s-operator
Jun 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [canonical/charming-actions](https://togithub.com/canonical/charming-actions) | action | minor | `2.4.0` -> `2.6.0` | --- ### Release Notes <details> <summary>canonical/charming-actions (canonical/charming-actions)</summary> ### [`v2.6.0`](https://togithub.com/canonical/charming-actions/releases/tag/2.6.0) [Compare Source](https://togithub.com/canonical/charming-actions/compare/2.4.0...2.6.0) #### What's Changed - bump deps and address vuln issues by [@​simskij](https://togithub.com/simskij) in [https://github.com/canonical/charming-actions/pull/110](https://togithub.com/canonical/charming-actions/pull/110) - chore(deps): pin dependencies by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/111](https://togithub.com/canonical/charming-actions/pull/111) - fix(renovate): Update patch (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/112](https://togithub.com/canonical/charming-actions/pull/112) - fix(renovate): Update actions/checkout action to v3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/115](https://togithub.com/canonical/charming-actions/pull/115) - fail channel action if branch name is invalid by [@​simskij](https://togithub.com/simskij) in [https://github.com/canonical/charming-actions/pull/105](https://togithub.com/canonical/charming-actions/pull/105) - fix(renovate): Update github-actions to v4 (major) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/117](https://togithub.com/canonical/charming-actions/pull/117) - fix(renovate): Update major (major) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/118](https://togithub.com/canonical/charming-actions/pull/118) - fix(renovate): Update dependency dayjs to ^1.11.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/120](https://togithub.com/canonical/charming-actions/pull/120) - fix(renovate): Update dependency typescript to v5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/116](https://togithub.com/canonical/charming-actions/pull/116) - fix(renovate): Update minor (minor) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/114](https://togithub.com/canonical/charming-actions/pull/114) - ci: run npm build during CI to ensure no failures by [@​jnsgruk](https://togithub.com/jnsgruk) in [https://github.com/canonical/charming-actions/pull/121](https://togithub.com/canonical/charming-actions/pull/121) - fix(renovate): Update patch to ^6.13.2 (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/122](https://togithub.com/canonical/charming-actions/pull/122) - fix(renovate): Update patch (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/123](https://togithub.com/canonical/charming-actions/pull/123) - read metadata from charmcraft.yaml by [@​addyess](https://togithub.com/addyess) in [https://github.com/canonical/charming-actions/pull/132](https://togithub.com/canonical/charming-actions/pull/132) - Support uploading multiple charm files by [@​sudeephb](https://togithub.com/sudeephb) in [https://github.com/canonical/charming-actions/pull/131](https://togithub.com/canonical/charming-actions/pull/131) - chore(style): Use same style on fields by [@​merkata](https://togithub.com/merkata) in [https://github.com/canonical/charming-actions/pull/126](https://togithub.com/canonical/charming-actions/pull/126) - docs(README): Add missing inputs by [@​merkata](https://togithub.com/merkata) in [https://github.com/canonical/charming-actions/pull/125](https://togithub.com/canonical/charming-actions/pull/125) - Add "dump-logs" action by [@​sed-i](https://togithub.com/sed-i) in [https://github.com/canonical/charming-actions/pull/133](https://togithub.com/canonical/charming-actions/pull/133) - make github tag in upload-charm optional by [@​lucabello](https://togithub.com/lucabello) in [https://github.com/canonical/charming-actions/pull/137](https://togithub.com/canonical/charming-actions/pull/137) - Update README.md by [@​cbartz](https://togithub.com/cbartz) in [https://github.com/canonical/charming-actions/pull/136](https://togithub.com/canonical/charming-actions/pull/136) - fix(renovate): Update actions/upload-artifact action to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/134](https://togithub.com/canonical/charming-actions/pull/134) - fix(renovate): Update patch (patch) by [@​renovate](https://togithub.com/renovate) in [https://github.com/canonical/charming-actions/pull/127](https://togithub.com/canonical/charming-actions/pull/127) - Fail release-libraries action if the lib has libpatch greater than expected version by [@​shayancanonical](https://togithub.com/shayancanonical) in [https://github.com/canonical/charming-actions/pull/135](https://togithub.com/canonical/charming-actions/pull/135) - add promote action by [@​lucabello](https://togithub.com/lucabello) in [https://github.com/canonical/charming-actions/pull/138](https://togithub.com/canonical/charming-actions/pull/138) #### New Contributors - [@​renovate](https://togithub.com/renovate) made their first contribution in [https://github.com/canonical/charming-actions/pull/111](https://togithub.com/canonical/charming-actions/pull/111) - [@​addyess](https://togithub.com/addyess) made their first contribution in [https://github.com/canonical/charming-actions/pull/132](https://togithub.com/canonical/charming-actions/pull/132) - [@​sudeephb](https://togithub.com/sudeephb) made their first contribution in [https://github.com/canonical/charming-actions/pull/131](https://togithub.com/canonical/charming-actions/pull/131) - [@​sed-i](https://togithub.com/sed-i) made their first contribution in [https://github.com/canonical/charming-actions/pull/133](https://togithub.com/canonical/charming-actions/pull/133) - [@​cbartz](https://togithub.com/cbartz) made their first contribution in [https://github.com/canonical/charming-actions/pull/136](https://togithub.com/canonical/charming-actions/pull/136) - [@​shayancanonical](https://togithub.com/shayancanonical) made their first contribution in [https://github.com/canonical/charming-actions/pull/135](https://togithub.com/canonical/charming-actions/pull/135) **Full Changelog**: canonical/charming-actions@2.4.0...2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 3am every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/mysql-router-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#86
Since
charmcraft publish-libexits with code 0 when publishing a library fails due to a higher than expected lib version, we are showing green builds in our CI when calling release-libraries actionSolution
publish-libif the error is encounterednpm audit fix