Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new documentation layout [WD-7866] #323

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

aaryanporwal
Copy link
Contributor

@aaryanporwal aaryanporwal commented Jan 5, 2024

Done

QA

  • Check out this feature branch
  • Run the site using the command dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8043/
  • Run through the following QA steps
  • [List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes #

Screenshots

Screenshot 2024-01-09 at 9 25 42 PM

@webteam-app
Copy link

Demo starting at https://anbox-cloud-io-323.demos.haus

@aaryanporwal aaryanporwal requested a review from edlerd January 5, 2024 10:09
@aaryanporwal aaryanporwal force-pushed the new-doc-layout branch 3 times, most recently from 31db39e to 955361e Compare January 5, 2024 10:21
templates/docs/document.html Outdated Show resolved Hide resolved
templates/partial/_navigation.html Outdated Show resolved Hide resolved
static/sass/_pattern_docs.scss Outdated Show resolved Hide resolved
templates/login/index.html Outdated Show resolved Hide resolved
templates/partial/_footer.html Show resolved Hide resolved
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion to improve the footer.

Another suggestion to make search results consistent with the docs pages.

.gitignore Outdated Show resolved Hide resolved
templates/partial/_footer.html Outdated Show resolved Hide resolved
templates/docs/search.html Outdated Show resolved Hide resolved
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA looks good now, thanks :)

The scss linter has some errors, can you have a look at it?

@aaryanporwal aaryanporwal force-pushed the new-doc-layout branch 2 times, most recently from c75ef6a to 759dfcd Compare January 10, 2024 07:14
@aaryanporwal
Copy link
Contributor Author

QA looks good now, thanks :)

The scss linter has some errors, can you have a look at it?

Just added a new commit to fix it, please take a look :)

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM, thanks for the changes and also including the new logo. I think the new logo looks fine.
Tiny nitpick below, then ready for merge from my side.

templates/partial/_navigation.html Outdated Show resolved Hide resolved
@aaryanporwal
Copy link
Contributor Author

Let me squash and make the commit history look better

@edlerd edlerd merged commit d127976 into canonical:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants