Skip to content

Commit

Permalink
eDSL: Fix method names (#2035)
Browse files Browse the repository at this point in the history
* Rename a few methods

* Catch up the user of those methods
  • Loading branch information
anshumanmohan authored May 7, 2024
1 parent 4257d90 commit 7b9ca1c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
14 changes: 8 additions & 6 deletions calyx-py/calyx/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,9 @@ def reg(self, size: int, name: str = None, is_ref: bool = False) -> CellBuilder:
if name:
assert isinstance(name, str), f"name {name} is not a string"
if is_ref and not name:
raise ValueError("A register that will be passed by reference must have a name.")
raise ValueError(
"A register that will be passed by reference must have a name."
)
name = name or self.generate_name("reg")
return self.cell(name, ast.Stdlib.register(size), False, is_ref)

Expand Down Expand Up @@ -576,9 +578,9 @@ def reg_store(self, reg, val, groupname=None):
reg_grp.done = reg.done
return reg_grp

def mem_load_std_d1(self, mem, i, reg, groupname=None):
def mem_load_comb_mem_d1(self, mem, i, reg, groupname=None):
"""Inserts wiring into `self` to perform `reg := mem[i]`,
where `mem` is a std_d1 memory.
where `mem` is a comb_mem_d1 memory.
"""
assert mem.is_comb_mem_d1()
groupname = groupname or f"{mem.name()}_load_to_reg"
Expand All @@ -589,9 +591,9 @@ def mem_load_std_d1(self, mem, i, reg, groupname=None):
load_grp.done = reg.done
return load_grp

def mem_store_std_d1(self, mem, i, val, groupname=None):
def mem_store_comb_mem_d1(self, mem, i, val, groupname=None):
"""Inserts wiring into `self` to perform `mem[i] := val`,
where `mem` is a std_d1 memory."""
where `mem` is a comb_mem_d1 memory."""
assert mem.is_comb_mem_d1()
groupname = groupname or f"store_into_{mem.name()}"
with self.group(groupname) as store_grp:
Expand Down Expand Up @@ -642,7 +644,7 @@ def mem_store_seq_d1(self, mem, i, val, groupname=None):

def mem_load_to_mem(self, mem, i, ans, j, groupname=None):
"""Inserts wiring into `self` to perform `ans[j] := mem[i]`,
where `mem` and `ans` are both std_d1 memories.
where `mem` and `ans` are both comb_mem_d1 memories.
"""
assert mem.is_comb_mem_d1() and ans.is_comb_mem_d1()
groupname = groupname or f"{mem.name()}_load_to_mem"
Expand Down
8 changes: 4 additions & 4 deletions calyx-py/calyx/gen_exp.py
Original file line number Diff line number Diff line change
Expand Up @@ -700,9 +700,9 @@ def build_base_not_e(degree, width, int_width, is_signed) -> Program:
ret = main.comb_mem_d1("ret", width, 1, 1, is_external=True)
f = main.comp_instance("f", "fp_pow_full")

read_base = main.mem_load_std_d1(b, 0, base_reg, "read_base")
read_exp = main.mem_load_std_d1(x, 0, exp_reg, "read_exp")
write_to_memory = main.mem_store_std_d1(ret, 0, f.out, "write_to_memory")
read_base = main.mem_load_comb_mem_d1(b, 0, base_reg, "read_base")
read_exp = main.mem_load_comb_mem_d1(x, 0, exp_reg, "read_exp")
write_to_memory = main.mem_store_comb_mem_d1(ret, 0, f.out, "write_to_memory")

main.control += [
read_base,
Expand Down Expand Up @@ -741,7 +741,7 @@ def build_base_is_e(degree, width, int_width, is_signed) -> Program:
t.write_en = 1
init.done = t.done

write_to_memory = main.mem_store_std_d1(ret, 0, e.out, "write_to_memory")
write_to_memory = main.mem_store_comb_mem_d1(ret, 0, e.out, "write_to_memory")

main.control += [
init,
Expand Down

0 comments on commit 7b9ca1c

Please sign in to comment.