Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS preflighting bit wonky #36

Open
calpaterson opened this issue Dec 8, 2020 · 1 comment
Open

CORS preflighting bit wonky #36

calpaterson opened this issue Dec 8, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@calpaterson
Copy link
Owner

Description

The extensions HTTP requests to the sync api get preflighted. Those requests look a bit wonky (and aren't directly tested).

Steps to reproduce

  1. Cause a full or partial sync
  2. Observe the preflight request

Expected result

  1. Preflight request is responded to pretty fast (
  2. Preflight response includes the correct caching headers

Actual result

Considerable doubt regarding #1 and #2

Additional details

Fix for this should include a specific test that checks it works (and that no DB activity is done) and that the speciai CORS caching headers are returned.

@calpaterson calpaterson added the bug Something isn't working label Dec 8, 2020
@calpaterson
Copy link
Owner Author

This probably requires splitting up the (remaining) main blueprint into one for the web ui and one for the sync api. Then get rid of Flask-CORS are write the OPTIONS endpoint by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant