-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Errno2 on GTFS RT validation #3553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
000764c
to
e7f3dd8
Compare
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
Signed-off-by: Erika Pacheco <erika@ministryofvelocity.com>
15cb151
to
483433d
Compare
483433d
to
8cb8db8
Compare
This PR lands two changes:
|
evansiroky
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohrite
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍐 w/ @erikamov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@ohrite and I refactored the code on
gtfs_rt_parser.py
using the tests created on the previous PR to then fix the issue #2780 to properly skip duplicate extracts instead of generating the error.Type of change
How has this been tested?
Tested locally:
Post-merge follow-ups
Check after the merge if the results on
cal-itp-data-infra.staging.int_gtfs_quality__rt_validation_outcomes
for next days/hours does not contain theErrno 2
reported on the issue.