Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FormatException in GitLabCILog when log message contains curly braces #189

Conversation

ap0llo
Copy link
Contributor

@ap0llo ap0llo commented Feb 16, 2024

Adjust call to IConsole.WriteLine() / IConsole.WriteErrorLine() in GitLabCILog to avoid that the log message is interpreted as format string.

Before, the following log call would throw a FormatException when runnign on GitLab CI:

context.Log.Information("{message}");

…aces

Adjust call to IConsole.WriteLine() / IConsole.WriteErrorLine() in GitLabCILog to avoid that the log message is interpreted as format string.
@nils-a nils-a force-pushed the fix-formatexception-when-log-message-contains-brackets branch from f589b29 to 745189d Compare February 16, 2024 22:22
@nils-a nils-a added the Bug label Feb 16, 2024
@nils-a nils-a added this to the vNext milestone Feb 16, 2024
@nils-a nils-a enabled auto-merge February 16, 2024 22:23
Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for getting this fixed!

@nils-a nils-a merged commit a285922 into cake-contrib:develop Feb 16, 2024
5 checks passed
@nils-a nils-a modified the milestones: vNext, 7.0.0 Feb 19, 2024
@cake-contrib-bot
Copy link

🎉 This issue has been resolved in version 7.0.0 🎉
The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants