Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single_proc not returning results #335

Closed
SeanMcOwen opened this issue Dec 21, 2023 · 3 comments
Closed

single_proc not returning results #335

SeanMcOwen opened this issue Dec 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@SeanMcOwen
Copy link
Contributor

Example of problem: https://github.com/BlockScience/PocketSimulationModel/blob/events/exploratory/cadCAD%200.5%20Test.ipynb
@SeanMcOwen
Copy link
Contributor Author

It can also be inferred only one simulation is run from timestamps

@SeanMcOwen
Copy link
Contributor Author

This line here seems to be the reason for only one simulation being run: https://github.com/cadCAD-org/cadCAD/blob/master/cadCAD/engine/execution.py#L29

danlessa added a commit to danlessa/cadCAD that referenced this issue Dec 21, 2023
@danlessa
fix issues cadCAD-org#335 & cadCAD-org#332
d7e38cb
@danlessa danlessa mentioned this issue Dec 21, 2023
Merged
@danlessa
Copy link
Member

This should be solved by PR #336

https://github.com/danlessa/cadCAD/tree/single_run_fix

emanuellima1 pushed a commit that referenced this issue Dec 21, 2023
@danlessa
Add row_count test + refactors on the final results processing + test…
8948757 
… parametrizations (#336)

* add tests for checking keys

* add tests

* fix issues #335 & #332

* parametrize test_runs

* add more tests

* fix subset ordering
@emanuellima1 emanuellima1 added the bug Something isn't working label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emanuellima1 @danlessa @SeanMcOwen