Skip to content

Commit

Permalink
Make tests more reliable avoiding false positives (#33)
Browse files Browse the repository at this point in the history
* Make tests more reliable avoiding false positives

* Restart cable server (and unsubscribe on redis) before each test

* two more sleeps and we are done

* Update src/cable/server.cr

remove unused variable

Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>

Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
  • Loading branch information
fernandes and jwoertink authored Oct 12, 2021
1 parent 8919a72 commit f83207a
Show file tree
Hide file tree
Showing 5 changed files with 156 additions and 119 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
crystal_version:
- 0.36.1
- 1.0.0
- 1.1.1
runs-on: ubuntu-latest
container: crystallang/crystal:${{ matrix.crystal_version }}-alpine
services:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Cable

![ci workflow](https://github.com/cable-cr/cable/actions/workflows/ci.yml/badge.svg)
[![ci workflow](https://github.com/cable-cr/cable/actions/workflows/ci.yml/badge.svg)](https://github.com/cable-cr/cable/actions/workflows/ci.yml)

It's like [ActionCable](https://guides.rubyonrails.org/action_cable_overview.html) (100% compatible with JS Client), but you know, for Crystal

Expand Down
Loading

0 comments on commit f83207a

Please sign in to comment.