EHD-1384: Minimise use of Obfuscator: Remove unused code

cabinetoffice · Oct 23, 2024 · 69eb505 · 69eb505
1 parent 67c57e7
commit 69eb505
Show file tree

Hide file tree

Showing 11 changed files with 3 additions and 48 deletions.
diff --git a/GenderPayGap.Core/Global.cs b/GenderPayGap.Core/Global.cs
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using Autofac;
-using GenderPayGap.Core.Models;
 using GenderPayGap.Extensions;
 using GenderPayGap.Extensions.AspNetCore;
 using Newtonsoft.Json;

diff --git a/GenderPayGap.Database/Models/Extensions/OrganisationAddress.cs b/GenderPayGap.Database/Models/Extensions/OrganisationAddress.cs
@@ -1,8 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using GenderPayGap.Core;
-using GenderPayGap.Core.Models;
 using GenderPayGap.Extensions;
 
 namespace GenderPayGap.Database

diff --git a/GenderPayGap.UnitTests/GenderPayGap.WebUI.Tests/BusinessLogicTests/BaseBusinessLogicTests.cs b/GenderPayGap.UnitTests/GenderPayGap.WebUI.Tests/BusinessLogicTests/BaseBusinessLogicTests.cs
diff --git a/...yGap.WebUI.Tests/BusinessLogicTests/Services/ScopeBusinessLogic/FillMissingScopesTests.cs b/...yGap.WebUI.Tests/BusinessLogicTests/Services/ScopeBusinessLogic/FillMissingScopesTests.cs
@@ -15,7 +15,7 @@ namespace GenderPayGap.BusinessLogic.Tests.ScopeBusinessLogic
 
     [TestFixture]
     [SetCulture("en-GB")]
-    public class FillMissingScopesTests : BaseBusinessLogicTests
+    public class FillMissingScopesTests
     {
 
         [SetUp]

diff --git a/...bUI.Tests/BusinessLogicTests/Services/ScopeBusinessLogic/FindOrgsWhereScopeNotSetTests.cs b/...bUI.Tests/BusinessLogicTests/Services/ScopeBusinessLogic/FindOrgsWhereScopeNotSetTests.cs
@@ -16,7 +16,7 @@ namespace GenderPayGap.BusinessLogic.Tests.ScopeBusinessLogic
 
     [TestFixture]
     [SetCulture("en-GB")]
-    public class FindOrgsWhereScopeNotSetTests : BaseBusinessLogicTests
+    public class FindOrgsWhereScopeNotSetTests
     {
 
         [SetUp]

diff --git a/GenderPayGap.WebUI/BackgroundJobs/ScheduledJobs/PurgeOrganisationsJob.cs b/GenderPayGap.WebUI/BackgroundJobs/ScheduledJobs/PurgeOrganisationsJob.cs
@@ -4,7 +4,6 @@
 using GenderPayGap.Core;
 using GenderPayGap.Core.Classes.Logger;
 using GenderPayGap.Core.Interfaces;
-using GenderPayGap.Core.Models;
 using GenderPayGap.Database;
 using GenderPayGap.Extensions;
 using GenderPayGap.Extensions.AspNetCore;

diff --git a/GenderPayGap.WebUI/Classes/Presentation/CompareViewService.cs b/GenderPayGap.WebUI/Classes/Presentation/CompareViewService.cs
@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Linq;
 using System.Web;
 using GenderPayGap.Core;
 using GenderPayGap.Core.Classes;

diff --git a/GenderPayGap.WebUI/ExternalServices/FileRepositories/AwsFileRepository.cs b/GenderPayGap.WebUI/ExternalServices/FileRepositories/AwsFileRepository.cs
@@ -5,7 +5,6 @@
 using Amazon.Runtime;
 using Amazon.S3;
 using Amazon.S3.Model;
-using GenderPayGap.Core.Models;
 using GenderPayGap.Extensions;
 
 namespace GenderPayGap.WebUI.ExternalServices.FileRepositories

diff --git a/GenderPayGap.WebUI/Models/Search/SearchApiResult.cs b/GenderPayGap.WebUI/Models/Search/SearchApiResult.cs
@@ -15,7 +15,6 @@ public class SearchApiResultEmployer
     {
 
         public long Id { get; set; }
-        public string EncId { get; set; }
         public string Name { get; set; }
         public string PreviousName { get; set; }
         public string Address { get; set; }

diff --git a/GenderPayGap.WebUI/Search/ViewingSearchService.cs b/GenderPayGap.WebUI/Search/ViewingSearchService.cs
@@ -1,6 +1,5 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
-using GenderPayGap.Core.Classes;
 using GenderPayGap.Core.Interfaces;
 using GenderPayGap.Database;
 using GenderPayGap.WebUI.Models.Search;
@@ -102,7 +101,6 @@ private SearchApiResultEmployer ConvertRankedOrgsToSearchApiResultEmployer(Ranke
             return new SearchApiResultEmployer
             {
                 Id = rankedViewingSearchOrganisation.ViewingSearchResult.OrganisationId,
-                EncId = Obfuscator.Obfuscate(rankedViewingSearchOrganisation.ViewingSearchResult.OrganisationId),
                 Name = rankedViewingSearchOrganisation.ViewingSearchResult.OrganisationName,
                 PreviousName = previousName,
                 Address = rankedViewingSearchOrganisation.ViewingSearchResult.Address,
@@ -119,7 +117,6 @@ private SearchApiResultEmployer ConvertToSearchApiResultEmployer(SearchCachedOrg
             return new SearchApiResultEmployer
             {
                 Id = searchCachedOrganisation.OrganisationId,
-                EncId = Obfuscator.Obfuscate(searchCachedOrganisation.OrganisationId),
                 Name = searchCachedOrganisation.OrganisationName.OriginalValue,
                 PreviousName = previousName,
                 Address = searchCachedOrganisation.Address,

diff --git a/GenderPayGap.WebUI/Startup.cs b/GenderPayGap.WebUI/Startup.cs
@@ -9,7 +9,6 @@
 using GenderPayGap.Core.Classes;
 using GenderPayGap.Core.Classes.Logger;
 using GenderPayGap.Core.Interfaces;
-using GenderPayGap.Core.Models;
 using GenderPayGap.Database;
 using GenderPayGap.Extensions.AspNetCore;
 using GenderPayGap.WebUI.BackgroundJobs;