Revert changes in SendReminderEmailsJob to fix bug

cabinetoffice · Sep 30, 2024 · 64694bd · 64694bd
1 parent d4b9138
commit 64694bd
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/GenderPayGap.WebUI/BackgroundJobs/ScheduledJobs/SendReminderEmailsJob.cs b/GenderPayGap.WebUI/BackgroundJobs/ScheduledJobs/SendReminderEmailsJob.cs
@@ -57,7 +57,7 @@ private void SendReminderEmailsAction(string runId)
 
         private void SendReminderEmailsForSectorType(SectorTypes sector, string runId, DateTime startTime)
         {
-            var activeReportingYears = ReportingYearsHelper.GetReportingYears(sector);
+            var activeReportingYears = GetActiveReportingYears(sector);
             foreach (int year in activeReportingYears)
             {
                 if (IsAfterEarliestReminderForReportingYear(sector, year))
@@ -316,5 +316,12 @@ private static List<int> GetReminderEmailDays()
             return reminderEmailDays;
         }
 
+        private static List<int> GetActiveReportingYears(SectorTypes sectorType)
+        {
+            return ReportingYearsHelper.GetReportingYears()
+                .Where(year => GetDeadlineDateForReportingYear(sectorType, year) > VirtualDateTime.Now)
+                .ToList();
+        }
+
     }
 }