Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to avoid creating individual instrument netcdfs #25

Closed
callumrollo opened this issue Oct 27, 2021 · 0 comments
Closed

Refactor to avoid creating individual instrument netcdfs #25

callumrollo opened this issue Oct 27, 2021 · 0 comments
Labels
refactor Will not change code functionality

Comments

@callumrollo
Copy link
Collaborator

As per comments by @jklymak in PR #14:

Maybe we should go back though and simplify the logic, because the seperate sensor streams were a hack anyway, and not integral to the processing.

I wonder if we can get rid of this hack, and just process without the prefix at all? That greatly simplifies all this code and we don't need to assume anything about the carrier instrument for each sensor.

@callumrollo callumrollo added the refactor Will not change code functionality label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Will not change code functionality
Projects
None yet
Development

No branches or pull requests

1 participant