Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polars dependency not being added in a fresh installation #190

Open
richardsc opened this issue Sep 11, 2024 · 3 comments
Open

polars dependency not being added in a fresh installation #190

richardsc opened this issue Sep 11, 2024 · 3 comments

Comments

@richardsc
Copy link
Collaborator

As noted in #188, when I install pyglider fresh, using miniconda on macOS14.5, the polars dependency is not installed, and has to be added manually. I tried on two different macOS machines (intel and arm), with the same result.

@callumrollo
Copy link
Collaborator

Thanks for raising this Clark! At the moment, the test matrix only tests against ubuntu-latest

os: ["ubuntu-latest"]

I'll put in a PR to add mac and windows. Hopefully that will show up the issue, as I don't have a mac here to test with.

@callumrollo
Copy link
Collaborator

It looks like polaras was added to the conda recipe in release 0.07 a couple of weeks ago

conda-forge/pyglider-feedstock@00083d8

Can you check if that resolves the issue? I'll still work on adding mac and windows to the test matrix to catch these issues earlier in future

@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Dec 13, 2024

Thanks for raising this Clark! At the moment, the test matrix only tests against ubuntu-latest

Just a note that this problem isn't something that can be picked up via CI (as that uses the development environment file). Instead it would require modifying the test: section in the feedstocks recipe.yml. Perhaps adding a simple test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants