-
Notifications
You must be signed in to change notification settings - Fork 360
Is this repo still maintained? #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I second this question. Though there are recent commits - perhaps additional help with maintaining the repo is needed to lighten the load? |
As a rough idea, what if:
If at any time c-bata comes back online they could then decide, based on the success of this fork, to either
Reasons for some of the proposed steps:
What I truly don't know is to which degree there's enough force to come up with a set of volunteers, and at which point a repo is considered large enough to allow to stem this kind of stuff. Does anyone have some thoughts here? Or, possibly even experience in such matters? |
This still seems to be an issue and go-prompt seems to be unmaintained or abandoned. We had a similar issue with https://github.com/labstack/echo where the original maintainer ran out of time. New maintainers stepped in (added to the original repo) and the project is alive again. @c-bata Do you see any chance to add additional maintainers to this repo? |
Hi, |
A few forks are active https://useful-forks.github.io/?repo=c-bata/go-prompt. |
@phanirithvij I'm the maintainer of https://github.com/elk-language/go-prompt. I've merged a lot of PR's from this repo, so there should be less bugs. The library lacked some basic features that I was looking for like syntax highlighting, buffered multiline editing and automatic indentation. And the autocompletion was slightly broken. So I did a major rewrite of the rendering process, fixing many hidden bugs along the way. Because of that, there are quite a few breaking changes between the original library and my fork. That's why I published a new major version All of the changes have been documented in the changelog https://github.com/elk-language/go-prompt/blob/master/CHANGELOG.md. So unfortunately my fork won't be a drop in replacement. But I think it's for the better. A lot of bugs present because of the flaky design were removed that way and the library is now suitable for building a fully featured REPL for a programming language. If you've got any ideas on how to improve my fork I'd be thrilled to read them in an issue. |
@Verseth thanks for the response I don't mind the breaking changes but I am talking about a regression, issues are disabled in your repo could you enable them? I'd like to file a regression. |
@viliamjr are you open to giving @go-prompt for this project? |
Hi. Yes, it will be a pleasure. |
I wasn't a contributor to this project. But I am very much interested in reviving this project. I asked about it because I saw several forks still trying to maintain the project. If no one has a problem with me receiving the ownership (or temporary ownership), I will use it to get the project back up and find the right people to maintain it. |
I'm considering maintaining a fork but would also be open to helping maintain this repo. Either way thank you for your awesome work!
The text was updated successfully, but these errors were encountered: