Skip to content

Is this repo still maintained? #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chriswalz opened this issue Nov 10, 2020 · 11 comments
Open

Is this repo still maintained? #212

chriswalz opened this issue Nov 10, 2020 · 11 comments

Comments

@chriswalz
Copy link

chriswalz commented Nov 10, 2020

I'm considering maintaining a fork but would also be open to helping maintain this repo. Either way thank you for your awesome work!

@dertseha
Copy link

I second this question. Though there are recent commits - perhaps additional help with maintaining the repo is needed to lighten the load?
I'd be happy to help out as well.
Forking seems a difficult choice, as then there's the question which one to take :)

@dertseha
Copy link

As a rough idea, what if:

  • Someone (who?) creates a GitHub org named something like "go-prompt" (name?)
  • This repo here is reproduced in that org (not cloned)
  • A group of volunteers (who?) is added as maintainers (or owners), which then go on to do:
  • As a first priority, the pending PRs here are reproduced and merged there, possibly massaged to clean up any conflicts
  • The problem reports about bugs reported here are reproduced and fixed there, where applicable/possible
  • Remaining issues (feature requests, ...) are then taken over.

If at any time c-bata comes back online they could then decide, based on the success of this fork, to either

  • a) merge back any changes happened in the fork and re-kindle this repo here
  • b) possibly also join the org and even move this repo to there, so that forwards work - or
  • c) archive this repo here and let the new one be the spiritual successor

Reasons for some of the proposed steps:

  • An org may provide an easier way to organize a group of maintainers and possibly successors, because it's not under someone's name
  • Because of option C I'd reproduce the repo instead of having the "forked from" tag for eternity

What I truly don't know is to which degree there's enough force to come up with a set of volunteers, and at which point a repo is considered large enough to allow to stem this kind of stuff.
Also, there was a (small) PR accepted fairly recently - though there's a list of other things pending.
And I don't know whether my idea makes things more complicated than they need be.

Does anyone have some thoughts here? Or, possibly even experience in such matters?

@lammel
Copy link

lammel commented Feb 7, 2022

This still seems to be an issue and go-prompt seems to be unmaintained or abandoned.
This project is awesome, but there are quite some PRs waiting to be merged (also including important bug fixes)

We had a similar issue with https://github.com/labstack/echo where the original maintainer ran out of time. New maintainers stepped in (added to the original repo) and the project is alive again.

@c-bata Do you see any chance to add additional maintainers to this repo?
Or could you comment on moving go-prompt to it's own org. Your insights would be very valuable.

@sinux-l5d
Copy link

Hi,
Just to let know everyone arriving here: I've contacted the maintainer on Twitter the 25th of April, never had a reply (and he's still active on twitter).
Guess we'll have to find another library, or wait for someone to fork this one.

@phanirithvij
Copy link

phanirithvij commented Sep 16, 2023

A few forks are active https://useful-forks.github.io/?repo=c-bata/go-prompt.
The most worked on/active being https://github.com/elk-language/go-prompt
- But the original examples are broken, and the new examples are a regression on my machine (linux)

@Verseth
Copy link

Verseth commented Sep 16, 2023

@phanirithvij I'm the maintainer of https://github.com/elk-language/go-prompt.

I've merged a lot of PR's from this repo, so there should be less bugs.

The library lacked some basic features that I was looking for like syntax highlighting, buffered multiline editing and automatic indentation. And the autocompletion was slightly broken.

So I did a major rewrite of the rendering process, fixing many hidden bugs along the way.

Because of that, there are quite a few breaking changes between the original library and my fork.

That's why I published a new major version 1.1.5 compared to the version of the original library: 0.2.6.

All of the changes have been documented in the changelog https://github.com/elk-language/go-prompt/blob/master/CHANGELOG.md.

So unfortunately my fork won't be a drop in replacement. But I think it's for the better. A lot of bugs present because of the flaky design were removed that way and the library is now suitable for building a fully featured REPL for a programming language.

If you've got any ideas on how to improve my fork I'd be thrilled to read them in an issue.

@phanirithvij
Copy link

@Verseth thanks for the response I don't mind the breaking changes but I am talking about a regression, issues are disabled in your repo could you enable them? I'd like to file a regression.

@phanirithvij
Copy link

@viliamjr are you open to giving @go-prompt for this project?

@viliamjr
Copy link

@viliamjr are you open to giving @go-prompt for this project?

Hi. Yes, it will be a pleasure.
Can I send to you (@phanirithvij) a membership invite?
And then give to you ownership privileges (removing myself).

@phanirithvij
Copy link

I wasn't a contributor to this project. But I am very much interested in reviving this project.

I asked about it because I saw several forks still trying to maintain the project.

If no one has a problem with me receiving the ownership (or temporary ownership), I will use it to get the project back up and find the right people to maintain it.

@phanirithvij
Copy link

Thank you @viliamjr.

opened #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants