Skip to content

Commit

Permalink
pylint ignore duplicate code warnings for flows' create build snippet…
Browse files Browse the repository at this point in the history
…s methods
  • Loading branch information
KeenanRileyFaulkner committed Nov 6, 2023
1 parent 9df4579 commit 89e55df
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions bfasst/ninja_flows/vivado_phys_netlist.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ def create_rule_snippets(self):
self.phys_netlist_tool.create_rule_snippets()

def create_build_snippets(self):
# pylint: disable=duplicate-code
self.vivado_synth_tool.create_build_snippets()
self.vivado_impl_tool.create_build_snippets()
self.phys_netlist_tool.create_build_snippets(
impl_dcp=self.vivado_impl_tool.outputs["impl_checkpoint"],
impl_edf=self.vivado_impl_tool.outputs["impl_edf"],
)
# pylint: enable=duplicate-code

def add_ninja_deps(self, deps):
self.vivado_synth_tool.add_ninja_deps(deps)
Expand Down
2 changes: 2 additions & 0 deletions bfasst/ninja_flows/vivado_phys_netlist_cmp.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def create_rule_snippets(self):
self.compare_tool.create_rule_snippets()

def create_build_snippets(self):
# pylint: disable=duplicate-code
self.vivado_synth_tool.create_build_snippets()
self.vivado_impl_tool.create_build_snippets()
self.phys_netlist_tool.create_build_snippets(
Expand All @@ -39,6 +40,7 @@ def create_build_snippets(self):
netlist_b=self.phys_netlist_tool.outputs["viv_impl_physical_v"],
log_name="struct_cmp.log",
)
# pylint: enable=duplicate-code

def add_ninja_deps(self, deps):
self.vivado_synth_tool.add_ninja_deps(deps)
Expand Down
2 changes: 2 additions & 0 deletions test/flows/test_vivado_conformal_flow.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def test_build_snippets_exist(self):
self.assertEqual(build_statement_count, 8)

def test_add_ninja_deps(self):
"""Test that the flow adds the correct dependencies to the ninja build file
for reconfiguration"""
observed = ["foo", "bar"]
self.flow.add_ninja_deps(observed)
expected = ["foo", "bar"]
Expand Down
2 changes: 2 additions & 0 deletions test/flows/test_vivado_yosys_impl_flow.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ def test_build_snippets_exist(self):
self.assertEqual(build_statement_count, 9)

def test_add_ninja_deps(self):
"""Test that the flow adds the correct dependencies to the ninja build file
for reconfiguration"""
observed = ["foo", "bar"]
self.flow.add_ninja_deps(observed)
expected = ["foo", "bar"]
Expand Down

0 comments on commit 89e55df

Please sign in to comment.