Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Rid of IP type #69

Open
andrewthad opened this issue Oct 15, 2020 · 1 comment
Open

Get Rid of IP type #69

andrewthad opened this issue Oct 15, 2020 · 1 comment

Comments

@andrewthad
Copy link
Member

This library offers three types for IP addresses: IPv4, IPv6, and IP. Two of these, IP and IPv6, are the same thing, but IP has special provisions for mapped IPv4 addresses. The newtype is only used to distinguish JSON instances. I think we can drop the newtype and leave the Net.IP module mostly alone, switching all the types to IPv6. There's the question of what the JSON instances for IPv6 should do, and I think that showing mapped IPv4 addresses in JSON as a plain old dot-decimal-encoded IPv4 address is what most people will want.

@chessai
Copy link
Member

chessai commented Oct 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants