fix: STORE FLAGS for iCloud and other strict IMAP servers #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any FLAG command params as shown in the examples of (RFC3501)[https://datatracker.ietf.org/doc/html/rfc3501#section-6.4.6] If the brackets aren't added, the command fails with To fix this, wrap the params of a STORE command in a Signed-off-by: Anna Larch <anna@nextcloud.com>
bytestream
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Seems more like a bug in Apple's implementation based on the linked RFC. They've clearly interpreted FLAGS <flag list> in section 6.4.6 to only use this part of the ABNF:
flag-list = "(" [flag *(SP flag)] ")"
If you read the ABNF though it clearly states:
store = "STORE" SP sequence-set SP store-att-flags
store-att-flags = (["+" / "-"] "FLAGS" [".SILENT"]) SP (flag-list / (flag *(SP flag)))
Given both parenthesised and not are valid this should be OK. However, I wouldn't be surprised if there's the alternative case where the IMAP server doesn't want a parenthesised list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any FLAG command params as shown in the examples of RFC3501.
If the brackets aren't added, the command fails with
BAD Parse Errorfor the\DeletedFLAGbut the
\SeenFLAG doesn't take effect either, which I haven't been able to track down just yet.To fix this, wrap the params of a STORE command in a
Horde_Imap_Client_Data_Format_ListTo Do:
\Seenflag for the same issue -\SeenFLAG now is synced across.