Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bitsail-connector-unified-kafka.json #498

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

lfyzjck
Copy link
Contributor

@lfyzjck lfyzjck commented Nov 28, 2023

Prepare a Pull Request

  • Title: [BitSail-497][ConnectorType] Register KafkaConnector

  • Fixes: #XYZ

Motivation

Register kafka-unified-connector

Modifications

add a json file to describe plugin config

Verifying this change

Please pick either of the following options.

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests, example:)

    • com.bytedance.bitsail.core.EngineTest#testRunEngine
  • This change added tests and can be verified as follows:

    (example:)

    • Added unit tests for parsing of configs
    • Optimized integration tests for recovery after task failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@hk-lrzy hk-lrzy merged commit 21dceb3 into bytedance:master Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants