Synchronize some component model intrinsics with the spec #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify some callers/accessors by plumbing around this whole structure instead of having some intrinsics just have portions where others have more.
Refactor some internals of async stream/future read/write and `task.return` to avoid passing `Function` and instead just pass then name around.
Don't so heavily nest the variables here indentation-wise.
This commit refactors the integration of async intrinsics into wit-component to support future changes to the `task.return` intrinsic. The refactoring here moves detection of intrinsics to all be in the same path rather than having one path which handles async intrinsics, another patch which handles resource intrinsics, and another path which handles `task.return` intrinsics. By handling everything in one location it's easier to ensure that everything is handled uniformly and various bits and pieces of contextual information are also easily available. This refactoring additionally updates the names recognized for async intrinsics. Previously for example async imports might use `[import-payload]` which is now no longer required. Additionally async imports might use `[export-payload]` too and that's changed to be `[export]` to match how other exports are handled as well.
This commit goes through a few component model intrinsics and synchronizes them with the current specification, mainly centered around async intrinsics. This doesn't synchronize all of them but is at least a start. Changes here include: * Support for `resource.drop async` intrinsics. * Renaming `task.backpressure` to `backpressure.set`. * Adding canonical ABI options to `task.return`. * A number of refactorings to simplify some constructs, reduce duplication, etc. The validation of `task.return` has been updated to take WebAssembly/component-model#453 into account with the new set of options that are allowed on it. Additionally `wit-component` was updated to set options for `task.return` in the same manner as the `canon lift`'d function on the other end.
|
I'll note that this is based on #2064, so only the last commit is exclusive to the PR (at this time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit goes through a few component model intrinsics and
synchronizes them with the current specification, mainly centered around
async intrinsics. This doesn't synchronize all of them but is at least a
start. Changes here include:
resource.drop asyncintrinsics.task.backpressuretobackpressure.set.task.return.duplication, etc.
The validation of
task.returnhas been updated to takeWebAssembly/component-model#453 into account with the new set of options
that are allowed on it. Additionally
wit-componentwas updated to setoptions for
task.returnin the same manner as thecanon lift'dfunction on the other end.