fix login

GithubBackup/GithubBackup.Cli.Tests/Commands/Github/Login/LoginArgsTests.cs

@@ -44,13 +44,13 @@ public async Task InvokeAsync_ShortFlagsArePassed_FlagsGetParsed()
             {
                 loginArgs.Should().NotBeNull();
                 loginArgs.Token.Should().Be("token");
-                loginArgs.DeviceFlowAuth.Should().BeTrue();
+                loginArgs.DeviceFlowAuth.Should().BeFalse();
             },
             new LoginArgsBinder(_loginArguments)
         );
 
         rootCommand.AddCommand(subCommand);
-        await TestCommandline.Build(rootCommand).InvokeAsync("sub -t token -dfa");
+        await TestCommandline.Build(rootCommand).InvokeAsync("sub -t token");
     }
 
     [Fact]

GithubBackup/GithubBackup.Cli.Tests/Commands/Github/Login/LoginRunnerTests.RunAsync_QuietAndDeviceAuthFlow_DoNotWriteToConsoleAndLoginUsingDeviceAuthFlow.verified.txt

@@ -1,3 +1 @@
-Go to verificationUri
-and enter userCode
-You have 60 seconds to authenticate before the code expires.
+verificationUri - userCode

GithubBackup/GithubBackup.Cli/Commands/Github/Login/LoginArgDescriptions.cs

@@ -5,6 +5,7 @@ internal static class LoginArgDescriptions
     public static readonly Description Token = new("Token", "Token",
         """
         If not provided, the token will be aquired from the environment variable GITHUB_BACKUP_TOKEN.
+        If a home directory is configured, the token will be stored in the file {home}/github-backup/token.
         If provided, device flow authentication will be ignored. Recommended for use on servers.");
         """
     );

GithubBackup/GithubBackup.Cli/Commands/Github/Login/LoginArguments.cs

@@ -10,7 +10,7 @@ public class LoginArguments
     ) { IsRequired = false };
 
     public Option<bool> DeviceFlowAuthOption { get; } = new(
-        aliases: new[] { "-dfa", "--device-flow-auth" },
+        aliases: new[] { "-d", "--device-flow-auth" },
         getDefaultValue: () => false,
         description: LoginArgDescriptions.DeviceFlowAuth.Long
     ) { IsRequired = false };

GithubBackup/GithubBackup.Cli/Commands/Github/Login/LoginRunner.cs

@@ -80,9 +80,18 @@ private async Task<User> LoginAsync(CancellationToken ct)
     private async Task<string> GetOAuthTokenAsync(CancellationToken ct)
     {
         var deviceAndUserCodes = await _authenticationService.RequestDeviceAndUserCodesAsync(ct);
-        _ansiConsole.WriteLine(
-            $"Go to {deviceAndUserCodes.VerificationUri}{Environment.NewLine}and enter {deviceAndUserCodes.UserCode}");
-        _ansiConsole.WriteLine($"You have {deviceAndUserCodes.ExpiresIn} seconds to authenticate before the code expires.");
+
+        if (!_globalArgs.Quiet)
+        {
+            _ansiConsole.WriteLine(
+                $"Go to {deviceAndUserCodes.VerificationUri}{Environment.NewLine}and enter {deviceAndUserCodes.UserCode}");
+            _ansiConsole.WriteLine($"You have {deviceAndUserCodes.ExpiresIn} seconds to authenticate before the code expires.");
+        }
+        else
+        {
+            _ansiConsole.WriteLine($"{deviceAndUserCodes.VerificationUri} - {deviceAndUserCodes.UserCode}");
+        }
+
         var accessToken = await _authenticationService.PollForAccessTokenAsync(
             deviceAndUserCodes.DeviceCode,
             deviceAndUserCodes.Interval,

GithubBackup/GithubBackup.Core/Github/Authentication/AuthenticationService.cs

@@ -63,6 +63,11 @@ public async Task<AccessToken> PollForAccessTokenAsync(string deviceCode, int in
             )
             .ReceiveJson<AccessTokenResponse>(), ct);
 
+        if (string.IsNullOrWhiteSpace(response.AccessToken))
+        {
+            throw new Exception("Authentication failed. No access token received. Please try again.");
+        }
+
         return new AccessToken(response.AccessToken!, response.TokenType!, response.Scope!);
     }