Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this "project" alive? #227

Open
SamMousa opened this issue Oct 3, 2022 · 3 comments
Open

Is this "project" alive? #227

SamMousa opened this issue Oct 3, 2022 · 3 comments

Comments

@SamMousa
Copy link

SamMousa commented Oct 3, 2022

I realize that the PHP sdk consists mostly of generated code, that is not what this is about.

There are a lot of open issues that seem to get no attention from anyone at Bunq.
In the latest version of the generated code there are issues with the library of classes extending non-existing classes, things that can be easily caught by automated static analysis of the generated code.

Is there any desire to make this a mature SDK or is it actually better to just use the well documented API and roll your own API client?

@d0x7
Copy link
Contributor

d0x7 commented Dec 15, 2022

They don't give a shit about this at all. Once in a while, they accept PRs but that's about it. Both this API and Java are completely broken by their bot. Their bot always does something, I guess somehow regenerating it according to current OpenAPI spec, but that does not work with the code that was written manually, hence breaking it. Both Java and PHP are missing classes such as CardPrimaryAccountNumber (used in Card.php#150 for PHP and Card.java#156) or for the Java SDK, there's a class called NotificationFilterPushUserInternal which, according to README should be used instead of the generated NotificationFilterPushUser, but the NotificationFilterPushUser doesn't even exist because the Bot deleted it ~15 versions ago and therefore the last ~15 Jitpack builds are constantly failing because of missing classes. It's a big, big mess honestly.

@SamMousa
Copy link
Author

Yup, we're planning on sunsetting our integration with Bunq as soon as we can.

@d0x7
Copy link
Contributor

d0x7 commented Dec 15, 2022

Oh wow, that was a quick reply. Yeah wish I could do the same. I'm not using in a business way, but because it's my private bank. And for a small webapp, I need to access the bunq API. I've used the PHP one before and it's still in use in my project and still working, but it seems the newer versions are patched broken as I just said. I'm rewriting said app as a microservice in java right now, therefore I need the Java API now. I'm mostly just removing the broken references as I don't personally need them, but it's still stupid. I might try to generate a brand new client from the API spec, check what's not working with a generated client, fix that and upload it to GH, but I most likely won't have the time to keep this always updated when they change their spec - unless it's breaking my application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants