Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/58 - Rename constants concerning PascalCase convention #68

Closed
wants to merge 1 commit into from
Closed

feature/58 - Rename constants concerning PascalCase convention #68

wants to merge 1 commit into from

Conversation

kid-cavaquinho
Copy link

This PR closes/fixes the following issues:

@OGKevin
Copy link
Contributor

OGKevin commented Dec 27, 2017 •
edited
Loading

Hey @AnTao,

Thanks for this pr!

However there are some issues:

  1. Could you please revert the changes in all the generated files. As explained here: Rename constants to PascalCase #58 (comment)

  2. The pr template has not been merged yet and therefore you might have missed the commit pattern explanation. Could you please rebase your commit and rename it according to the following regex: '([A-Za-z0-9 ]+)\. (\(bunq\/sdk_csharp#[0-9]+\))'

@OGKevin OGKevin added this to the 0.12.5 milestone Dec 27, 2017
@kid-cavaquinho kid-cavaquinho deleted the feature/58-pascalcase-constants branch December 27, 2017 14:16
@OGKevin OGKevin removed this from the 0.12.5 milestone Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kid-cavaquinho kid-cavaquinho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename constants to PascalCase
2 participants
@kid-cavaquinho @OGKevin