Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generator to check nullable types with HasValue() #75

Open
epels opened this issue Jan 2, 2018 · 0 comments
Open

Update generator to check nullable types with HasValue() #75

epels opened this issue Jan 2, 2018 · 0 comments
Labels
code style enhancement needs code regeneration

Comments

@epels
Copy link

epels commented Jan 2, 2018

Steps to reproduce:

  1. Have a generated type with a nullable field (e.g. MasterCardAction.CardId is an int?)
  2. Check if the field is null in generated code

What should happen:

  1. Checked with myNullableField.HasValue

What happens:

  1. Checked with myNullableField != null
@OGKevin OGKevin added this to the 0.13.0 milestone Jan 5, 2018
@OGKevin OGKevin modified the milestones: 0.13.0, 0.13.5 Mar 27, 2018
@OGKevin OGKevin modified the milestones: 1.0.0, 1.1.0 Jul 24, 2018
@angelomelonas angelomelonas removed this from the 1.1.0 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code style enhancement needs code regeneration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kojoru @epels @angelomelonas @OGKevin