-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: update dependencies and use Node 20 #508
Conversation
5848ca9
to
29b1b5d
Compare
29b1b5d
to
7f3b23e
Compare
9a9000f
to
0cce878
Compare
3025e7a
to
f0fb677
Compare
f0fb677
to
9f32693
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot for this huge work 🙏
bfa73b4
to
b8746e0
Compare
Hi Phil, thanks for the ping. I indeed would love to be able to merge this in, but there's still an issue in the packaging with the new ESM mode which is driving me crazy 😅. I've had to leave it as is for now, but it's almost there. Luckily I should have some time to look at it and merge this ASAP (definitely will do in march. Thanks for the heads up |
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
a95208f
to
70f9e88
Compare
Down the rabbit hole of ESM...
Instead of manually setting an extra env var for a custom user agent, let's properly use oclif's configuration to be able to read the current repos' package.json. Thus the user agent sent by the github action will include the package.json's `name` value.
70f9e88
to
22fe171
Compare
22fe171
to
5d86869
Compare
CI is green, and full integration testing of this branch seems to work fine 🎉 🎉 🎉 (😌 pfiou it was a much longer road than expected 😅) |
Logs of unit tests
Logs of running the action with `local-action` package