Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the old --flatten --flatten-include feature to have a clean baseline for the new --flatten one #1912

Closed
wants to merge 2 commits into from
Closed

Get rid of the old --flatten --flatten-include feature to have a clean baseline for the new --flatten one #1912

wants to merge 2 commits into from

Conversation

dlion
Copy link
Member

@dlion dlion commented Sep 19, 2023 •
edited
Loading

Summary

This is the starting point for the Flatten RFC.
The aim of this PR is to get rid of the old code about the flatten feature and re-implement it according to buildpacks/rfcs#290

Before

pack build --experimental --flatten --flatten-include

After

pack build --flatten

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Baseline PR for #1914

@dlion dlion added experimental Issue or PR refers to an experimental feature. flatten feature labels Sep 19, 2023
@dlion dlion requested review from a team as code owners September 19, 2023 15:12
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Sep 19, 2023
@github-actions github-actions bot added this to the 0.31.0 milestone Sep 19, 2023
@natalieparellano
Copy link
Member

Just to clarify, is the aim to re-implement the feature according to buildpacks/rfcs#290 before we ship another pack?

@jjbustamante
Copy link
Member

Just to clarify, is the aim to re-implement the feature according to buildpacks/rfcs#290 before we ship another pack?

Yes, that's the idea 😄 . I think @dlion was so happy to remove code that the name of the PR indicates we want to remove the feature

@dlion dlion changed the title Removed Flatten feature from Pack Get rid of the old --flatten --flatten-include feature to have a clean baseline for the new --flatten one Sep 20, 2023
@dlion
Copy link
Member Author

dlion commented Sep 20, 2023

Ups, yeah thanks for clarifying @natalieparellano ! ❤️
I edited the title and enriched the description.
Indeed this is just the first step which will allow us to start from scratch for the new implementation 😄

Domenico Luciani added 2 commits September 20, 2023 18:17
Removed evry part of the code related with flatten feature
8ff6c79 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Removed unused code and formatted
61f276c 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@dlion dlion mentioned this pull request Sep 28, 2023
Closed
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@jjbustamante jjbustamante modified the milestones: 0.33.0, 0.32.0 Oct 31, 2023
@jjbustamante
Copy link
Member

Closing this PR in favor of #1985

@jjbustamante jjbustamante removed this from the 0.33.0 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experimental Issue or PR refers to an experimental feature. flatten feature type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlion @natalieparellano @jjbustamante