Merge pull request #98 from buildkite/correctly-encode-urls

Correct encode backslashes in URLs
buildkite · Apr 7, 2015 · 0fd95d7 · 0fd95d7
2 parents ba6152e + 26b2efc
commit 0fd95d7
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/buildkite/s3_uploader.go b/buildkite/s3_uploader.go
@@ -9,6 +9,7 @@ import (
 	"io/ioutil"
 	"os"
 	"strings"
+	"net/url"
 )
 
 type S3Uploader struct {
@@ -84,7 +85,11 @@ func (u *S3Uploader) Setup(destination string) error {
 }
 
 func (u *S3Uploader) URL(artifact *Artifact) string {
-	return "http://" + u.bucketName() + ".s3.amazonaws.com/" + u.artifactPath(artifact)
+  url, _ := url.Parse("http://" + u.bucketName() + ".s3.amazonaws.com")
+
+	url.Path += u.artifactPath(artifact)
+
+	return url.String()
 }
 
 func (u *S3Uploader) Upload(artifact *Artifact) error {