🛠️ - Typescript rules against: enums & interfaces #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartenBruggink
requested review from
PauloMFJ,
maikelvdzande and
brunotomedev
as code owners
PauloMFJ
suggested changes
Oct 4, 2023
PauloMFJ
reviewed
Oct 4, 2023
There was a problem hiding this comment.
These two rules partially go against the grain on what this package was trying to be:
Extended ESLint Rules
The idea behind this config is to enforce consistency across all projects. We've tried to keep the rules as minimal as possible, and for the most part simply inherit from the recommended rules of the plugins we use. The main exceptions are when it comes to the following. Note: We've purposely only defined rules that are auto fixable, these rules should make it easier to write code, and not get in the way.
Can we update the README to reflect the changes too? Would be nice to also explain the reasoning there.
PauloMFJ
previously approved these changes
Oct 4, 2023
…m/lint into feature/typescript-rules
PauloMFJ
suggested changes
Oct 4, 2023
PauloMFJ
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two Typescript specific eslint rules;
no-restricted-syntax - TSEnumDeclaration- Error when using Enums, let's push foras constsince it's more declarative that it outputs JS.@typescript-eslint/consistent-type-definitions- Error when using interfaces. The difference between interface and type is minimal and the one additional feature it supports we shouldn't use.Set nvm version to
v18