macOSでgolangci-lint runするとhandler/moq_test.goでERRORになる場合があるのと解消方法 #74

nnabeyang · 2022-11-20T01:31:35Z

nnabeyang
Nov 20, 2022

handler/moq_test.go生成以降、golangci-lint runするとエラーになることに気がつきました。

% golangci-lint run
WARN [runner] Can't run linter goanalysis_metalinter: goimports: can't extract issues from gofmt diff output "--- /Users/nabeyang/src/github.com/nnabeyang/go_todo_app/handler/moq_test.go.orig\t2022-11-20 10:07:05\n+++ /Users/nabeyang/src/github.com/nnabeyang/go_todo_app/handler/moq_test.go\t2022-11-20 10:07:05\n@@ -5,8 +5,9 @@\n \n import (\n \t\"context\"\n-\t\"github.com/nnabeyang/go_todo_app/entity\"\n \t\"sync\"\n+\n+\t\"github.com/nnabeyang/go_todo_app/entity\"\n )\n \n // Ensure, that ListTasksServiceMock does implement ListTasksService.\n": can't parse patch: parsing time "2022-11-20 10:07:05" as "2006-01-02 15:04:05 -0700": cannot parse "" as "-0700" 
ERRO Running error: 1 error occurred:
        * can't run linter goanalysis_metalinter: goimports: can't extract issues from gofmt diff output "--- /Users/nabeyang/src/github.com/nnabeyang/go_todo_app/handler/moq_test.go.orig\t2022-11-20 10:07:05\n+++ /Users/nabeyang/src/github.com/nnabeyang/go_todo_app/handler/moq_test.go\t2022-11-20 10:07:05\n@@ -5,8 +5,9 @@\n \n import (\n \t\"context\"\n-\t\"github.com/nnabeyang/go_todo_app/entity\"\n \t\"sync\"\n+\n+\t\"github.com/nnabeyang/go_todo_app/entity\"\n )\n \n // Ensure, that ListTasksServiceMock does implement ListTasksService.\n": can't parse patch: parsing time "2022-11-20 10:07:05" as "2006-01-02 15:04:05 -0700": cannot parse "" as "-0700"

次のイシューにコメントがついているようにbrew install diffutilsでdiffをgnuと互換?のものに変えることでエラーは発生しなくなりました。
golangci/golangci-lint#3087

budougumi0617 · 2022-11-27T16:20:00Z

budougumi0617
Nov 27, 2022
Maintainer

ご連絡遅くなり申し訳ありません。直っているみたいなPRもあるので確認してみます。。。！

build(deps): bump github.com/sourcegraph/go-diff to HEAD golangci/golangci-lint#3350

5 replies

nnabeyang Nov 27, 2022
Author

@budougumi0617 よろしくお願いします。このPRは20日前なので、僕が使ってたのは反映前のバージョンかもしれないですね。

budougumi0617 Dec 3, 2022
Maintainer

@nnabeyang せっかく起票していただいのたに対応が遅くなりました。
手元のM1 Macで試したところ10月リリースの最新版のgolangci-lintでも再現しなかったのですが何か他に条件ありますか？

$ go version
go version go1.19.3 darwin/arm64
$ pwd
/Users/budougumi0617/go/src/github.com/budougumi0617/go_todo_app
$ golangci-lint version
golangci-lint has version 1.50.1 built from 8926a95f on 2022-10-22T10:50:47Z
$ make generate
go generate ./...
$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   auth/moq_test.go
        modified:   handler/moq_test.go
        modified:   service/moq_test.go
        modified:   service/store_moq_test.go

no changes added to commit (use "git add" and/or "git commit -a")


$ golangci-lint run -v
INFO [config_reader] Config search paths: [./ /Users/golangci-lint run -v
INFO [config_reader] Config search paths: [./ /Users/budougumi0617/go/src/github.com/budougumi0617/go_todo_app /Users/budougumi0617/go/src/github.com/budougumi0617 /Users/budougumi0617/go/src/github.com /Users/budougumi0617/go/src /Users/budougumi0617/go /Users/budougumi0617 /Users /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 10 linters: [errcheck gocognit gocyclo gofmt goimports govet misspell staticcheck unused whitespace]
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|files|imports|deps|name|types_sizes) took 139.888959ms
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 2.703583ms
INFO [linters_context/goanalysis] analyzers took 0s with no stages
INFO [runner] Issues before processing: 9, after processing: 0
INFO [runner] Processors filtering stat (out/in): identifier_marker: 1/1, exclude: 1/1, cgo: 9/9, filename_unadjuster: 9/9, autogenerated_exclude: 1/9, exclude-rules: 0/1, path_prettifier: 9/9, skip_files: 9/9, skip_dirs: 9/9
INFO [runner] processing took 264.829µs with stages: autogenerated_exclude: 110.917µs, path_prettifier: 79.333µs, skip_dirs: 48.416µs, identifier_marker: 17.666µs, exclude-rules: 3.292µs, cgo: 1.459µs, filename_unadjuster: 834ns, nolint: 458ns, max_same_issues: 416ns, max_from_linter: 292ns, source_code: 292ns, severity-rules: 291ns, exclude: 249ns, skip_files: 208ns, uniq_by_line: 208ns, path_shortener: 125ns, diff: 124ns, path_prefixer: 83ns, sort_results: 83ns, max_per_file_from_linter: 83ns
INFO [runner] linters took 47.059917ms with stages: goanalysis_metalinter: 46.755167ms
INFO File cache stats: 0 entries of total size 0B
INFO Memory: 3 samples, avg is 42.8MB, max is 72.7MB
INFO Execution took 198.724417ms
/go/src/github.com/budougumi0617/go_todo_app /Users/budougumi0617/go/src/github.com/budougumi0617 /Users/budougumi0617/go/src/github.com /Users/budougumi0617/go/src /Users/yoichiroshimizu/go /Users/budougumi0617 /Users /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 10 linters: [errcheck gocognit gocyclo gofmt goimports govet misspell staticcheck unused whitespace]
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|files|imports|deps|name|types_sizes) took 139.888959ms
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 2.703583ms
INFO [linters_context/goanalysis] analyzers took 0s with no stages
INFO [runner] Issues before processing: 9, after processing: 0
INFO [runner] Processors filtering stat (out/in): identifier_marker: 1/1, exclude: 1/1, cgo: 9/9, filename_unadjuster: 9/9, autogenerated_exclude: 1/9, exclude-rules: 0/1, path_prettifier: 9/9, skip_files: 9/9, skip_dirs: 9/9
INFO [runner] processing took 264.829µs with stages: autogenerated_exclude: 110.917µs, path_prettifier: 79.333µs, skip_dirs: 48.416µs, identifier_marker: 17.666µs, exclude-rules: 3.292µs, cgo: 1.459µs, filename_unadjuster: 834ns, nolint: 458ns, max_same_issues: 416ns, max_from_linter: 292ns, source_code: 292ns, severity-rules: 291ns, exclude: 249ns, skip_files: 208ns, uniq_by_line: 208ns, path_shortener: 125ns, diff: 124ns, path_prefixer: 83ns, sort_results: 83ns, max_per_file_from_linter: 83ns
INFO [runner] linters took 47.059917ms with stages: goanalysis_metalinter: 46.755167ms
INFO File cache stats: 0 entries of total size 0B
INFO Memory: 3 samples, avg is 42.8MB, max is 72.7MB
INFO Execution took 198.724417ms

nnabeyang Dec 3, 2022
Author

@budougumi0617
diffはビルトインのものになっているでしょうか?appleのであれば、次のように出るはずです。

$diff --version
Apple diff (based on FreeBSD diff)

brew install diffutilsでgnu diffにしている場合は、次のように出ます。gnu diffの場合は、このエラーは出ないです。

$ diff --version
diff (GNU diffutils) 3.8
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Paul Eggert, Mike Haertel, David Hayes,
Richard Stallman, and Len Tower.

golangci-lintのバージョンは一致しているようです。実行ログを貼り付けます。

$ golangci-lint --version
golangci-lint has version 1.50.1 built from 8926a95 on 2022-10-22T10:48:48Z
$ golangci-lint run -v
INFO [config_reader] Config search paths: [./ /Users/nabeyang/src/github.com/budougumi0617/go_todo_app /Users/nabeyang/src/github.com/budougumi0617 /Users/nabeyang/src/github.com /Users/nabeyang/src /Users/nabeyang /Users /] 
INFO [config_reader] Used config file .golangci.yml 
INFO [lintersdb] Active 10 linters: [errcheck gocognit gocyclo gofmt goimports govet misspell staticcheck unused whitespace] 
INFO [loader] Go packages loading at mode 575 (exports_file|imports|types_sizes|compiled_files|files|name|deps) took 309.901291ms 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 2.133291ms 
INFO [linters_context/goanalysis] analyzers took 397.035825ms with top 10 stages: buildir: 225.560114ms, goimports: 54.738623ms, gofmt: 16.527167ms, unused: 9.217333ms, errcheck: 5.938665ms, SA1004: 5.754124ms, nilness: 4.620405ms, ctrlflow: 4.299213ms, misspell: 4.188294ms, SA4027: 4.117625ms 
WARN [runner] Can't run linter goanalysis_metalinter: goimports: can't extract issues from gofmt diff output "--- /Users/nabeyang/src/github.com/budougumi0617/go_todo_app/auth/moq_test.go.orig\t2022-12-04 08:31:39\n+++ /Users/nabeyang/src/github.com/budougumi0617/go_todo_app/auth/moq_test.go\t2022-12-04 08:31:39\n@@ -5,8 +5,9 @@\n \n import (\n \t\"context\"\n-\t\"github.com/budougumi0617/go_todo_app/entity\"\n \t\"sync\"\n+\n+\t\"github.com/budougumi0617/go_todo_app/entity\"\n )\n \n // Ensure, that StoreMock does implement Store.\n": can't parse patch: parsing time "2022-12-04 08:31:39" as "2006-01-02 15:04:05 -0700": cannot parse "" as "-0700" 
INFO [runner] processing took 2.249µs with stages: max_same_issues: 458ns, skip_files: 291ns, nolint: 250ns, max_from_linter: 250ns, cgo: 167ns, identifier_marker: 166ns, filename_unadjuster: 166ns, skip_dirs: 125ns, diff: 42ns, max_per_file_from_linter: 42ns, autogenerated_exclude: 42ns, sort_results: 42ns, uniq_by_line: 42ns, exclude-rules: 42ns, path_prefixer: 42ns, exclude: 41ns, path_prettifier: 41ns, source_code: 0s, path_shortener: 0s, severity-rules: 0s 
INFO [runner] linters took 178.739458ms with stages: goanalysis_metalinter: 178.715708ms 
ERRO Running error: 1 error occurred:
	* can't run linter goanalysis_metalinter: goimports: can't extract issues from gofmt diff output "--- /Users/nabeyang/src/github.com/budougumi0617/go_todo_app/auth/moq_test.go.orig\t2022-12-04 08:31:39\n+++ /Users/nabeyang/src/github.com/budougumi0617/go_todo_app/auth/moq_test.go\t2022-12-04 08:31:39\n@@ -5,8 +5,9 @@\n \n import (\n \t\"context\"\n-\t\"github.com/budougumi0617/go_todo_app/entity\"\n \t\"sync\"\n+\n+\t\"github.com/budougumi0617/go_todo_app/entity\"\n )\n \n // Ensure, that StoreMock does implement Store.\n": can't parse patch: parsing time "2022-12-04 08:31:39" as "2006-01-02 15:04:05 -0700": cannot parse "" as "-0700"
 
INFO Memory: 7 samples, avg is 53.4MB, max is 147.6MB 
INFO Execution took 589.982625ms

budougumi0617 Dec 4, 2022
Maintainer

ありがとうございます！diffutilsをbrew installした形跡はなかったのですが、GNUバージョンになっていたようです。
コードや書籍の記載が間違っているわけではないので注意書きをrepositoryに書いておこうと思います！

nnabeyang Dec 4, 2022
Author

@budougumi0617 了解しました。よろしくお願いします。

budougumi0617 · 2022-12-11T15:35:10Z

budougumi0617
Dec 11, 2022
Maintainer

対応がめちゃくちゃ遅くなってしまいました 🙇 正誤表に記載しました！

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

macOSでgolangci-lint runするとhandler/moq_test.goでERRORになる場合があるのと解消方法 #74

{{title}}

Replies: 2 comments 5 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

macOSでgolangci-lint runするとhandler/moq_test.goでERRORになる場合があるのと解消方法 #74

nnabeyang Nov 20, 2022

Replies: 2 comments · 5 replies

budougumi0617 Nov 27, 2022 Maintainer

nnabeyang Nov 27, 2022 Author

budougumi0617 Dec 3, 2022 Maintainer

nnabeyang Dec 3, 2022 Author

budougumi0617 Dec 4, 2022 Maintainer

nnabeyang Dec 4, 2022 Author

budougumi0617 Dec 11, 2022 Maintainer

nnabeyang
Nov 20, 2022

Replies: 2 comments 5 replies

budougumi0617
Nov 27, 2022
Maintainer

nnabeyang Nov 27, 2022
Author

budougumi0617 Dec 3, 2022
Maintainer

nnabeyang Dec 3, 2022
Author

budougumi0617 Dec 4, 2022
Maintainer

nnabeyang Dec 4, 2022
Author

budougumi0617
Dec 11, 2022
Maintainer