[DIP] Add benchmark for Buddy & OpenCV rotation operation. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshtag
suggested changes
May 29, 2023
zhanghb97
requested changes
Jun 7, 2023
The code have been reformat with |
|
Will delete the OpenCV enum class after exams(before the weekend). |
|
I expect the rotation operation to be improved from this PR. Shall we move ahead and review this once that patch lands? Or do you want me to move ahead with the review process now? Also, please mark the PR as "ready for review" once you think it is ready. |
- Use clang-format for rotate benchmark files.
If the acceleration PR changes the API, then it will be better to review that PR first. |
EllisLambda
pushed a commit
to EllisLambda/buddy-benchmark
that referenced
this pull request
Sep 21, 2023
…-compiler#63) * Add lit-test for correlation2D * Add correlation i32 test * Add support for i32 correlation 2d * Enable default attribute printing for DIP * Add a check for compatbility return type * Update lit test to find mlir cpu utils * Make output to be param for Corr2d - having it as a return value causes to segfault correlation2D sample - it is not clear how to return MemRef from C-interface * Mark attributes with <> in dip.mlir * Add a operand type check for Corr2D op and a test - Make sure that input, kernel, output and constant have the same value and use as inferred type - Adding a negative lit test to check params of the op * Fix review comments * Add support for i8,i64,f64 * Fix correlation2D_f64 test * by constructing F64 correctly * Fix review comment and formatting issues * Fix more review comment - extend correlation2d_invalid_type test to cover a condition for supported types - add comments for utility functions * Remove insertZeroConstantOp from LowerDIPPass - it is present in DIPItility.h * Trivial changes Co-authored-by: meshtag <prathameshtagore@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Buddy Rotate2D operation, use command
./image-processing-rotate-benchmark <image path> <Rotate option> <RotateAngle>. Here Rotate option available are DEGREE, RADIAN. RotateAngle accepts a float number for Rotate option.Examples:
./image-processing-rotate-benchmark ../../benchmarks/ImageProcessing/Images/YuTu.png RADIAN 1.57OR
./image-processing-rotate-benchmark ../../benchmarks/ImageProcessing/Images/YuTu.png DEGREE 45For OpenCV rotate(), it only supports 90, 180 and 270 degree. Only accepted when using DEGREE option and an integer( Num % 90 = 0). Like:
./image-processing-rotate-benchmark ../../benchmarks/ImageProcessing/Images/YuTu.png DEGREE 270