Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for testing DIP dialect's 2D correlation op with OpenCV #23

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

meshtag
Copy link
Member

@meshtag meshtag commented Jan 26, 2022

This PR intends to add support for testing dip.corr_2d's output with OpenCV.
All available kernels were used for correlating an image using DIP and OpenCV followed by comparison of their respective outputs.

Copy link
Member

@zhanghb97 zhanghb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think the test for the Corr2D result belongs to the integration test.
  • Can we try to use the GoogleTest framework to verify correctness? Because we are using the GoogleTest framework for other parts according to the previous discussions in our community.
  • Currently, the result shows all the cases are different, it's because opencv rounds up, right?

tests/UnitTests/ImageProcessing/DIPCorr2DTest.cpp Outdated Show resolved Hide resolved
@meshtag
Copy link
Member Author

meshtag commented Feb 1, 2022

I was thinking of moving test.h file in tests/ directory instead of tests/UnitTests/ directory so that I can add some functions in it for image processing tests which we are further planning to keep inside tests/IntegrationTests/ directory.
What is your opinion on this? (/cc @zhanghb97 @axmat)

@zhanghb97
Copy link
Member

moving test.h file in tests/ directory

What about moving to include/Utils ?

@meshtag meshtag marked this pull request as draft February 11, 2022 17:39
@meshtag meshtag marked this pull request as ready for review April 6, 2022 19:39
@zhanghb97
Copy link
Member

I run the ninja test && ninja image-processing-integration-tests
and got:

17/17 Test #17: FilterTest.OpenCVComparison .............***Failed    0.01 sec

94% tests passed, 1 tests failed out of 17

Total Test time (real) =   0.09 sec

The following tests FAILED:
         17 - FilterTest.OpenCVComparison (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util 
cd /root/buddy-benchmark/build-check && /usr/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.

EllisLambda pushed a commit to EllisLambda/buddy-benchmark that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants