-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for testing DIP dialect's 2D correlation op with OpenCV #23
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the test for the Corr2D result belongs to the integration test.
- Can we try to use the GoogleTest framework to verify correctness? Because we are using the GoogleTest framework for other parts according to the previous discussions in our community.
- Currently, the result shows all the cases are different, it's because opencv rounds up, right?
I was thinking of moving test.h file in |
What about moving to |
I run the
|
This PR intends to add support for testing
dip.corr_2d
's output with OpenCV.All available kernels were used for correlating an image using DIP and OpenCV followed by comparison of their respective outputs.