Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeAxis Date Range Picker does not work #10736

Closed
taauntik opened this issue Feb 4, 2025 · 1 comment
Closed

TimeAxis Date Range Picker does not work #10736

taauntik opened this issue Feb 4, 2025 · 1 comment
Assignees
Labels
bug Something isn't working forum Issues from forum regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@taauntik
Copy link

taauntik commented Feb 4, 2025

Forum post

Hi

we use the default implementation of the date ranger picker in scheduler pro, but unfortunatelly it does not work as you can see in your own example you provide.

https://bryntum.com/products/schedulerpro/examples/frameworks/vue-3-vite/basic/dist/

You can choose the date but it has no effect, after click it stays at 8th january.

msedge_yKM6qO9Nkk.mp4

The second problem I have with the picker is that you can only make the time range narrower.
How can I modify it so that I can make the time range wider?

Kind regards,
Patrick
2025-02-04 11_54_11-Bryntum Scheduler Pro - Basic setup (Vue 3 + Vite) und 14 weitere Seiten - Gesch.png
2025-02-04 11_37_50-Bryntum Scheduler Pro - Basic setup (Vue 3 + Vite) und 14 weitere Seiten - Gesch.png

@taauntik taauntik added bug Something isn't working forum Issues from forum labels Feb 4, 2025
@ExtAnimal
Copy link

Regressed here: https://github.com/bryntum/bryntum-suite/pull/10440/

The fix in DateField.js:

    changePicker(picker, oldPicker) {
        if (picker?.isDatePicker) {
            return picker;
        }
        const
            me     = this,
            config = DatePicker.mergeConfigs({
                owner        : me,
                forElement   : me.pickerAlignElement,
                minDate      : me.min,
                maxDate      : me.max,
                weekStartDay : me._weekStartDay, // need to pass the raw value to let the component to use its default value

                align : {
                    anchor : me.overlayAnchor,
                    target : me.pickerAlignElement
                },

                internalListeners : {
                    selectionChange : {   // <=== fix
                        fn      : 'onPickerSelectionChange',
                        thisObj : me
                    }
                }
            }, picker);

        if (me.calendarContainerCls) {
            config.cls = me.calendarContainerCls;
        }

        // If we are in cleared state, the picker will also have no value.
        // But have it focused on today as a default.
        if (me.value) {
            config.value = me.value;
        }
        else if (!config.activeDate) {
            config.activeDate = new Date();
        }

        const result = DatePicker.reconfigure(oldPicker, picker ? config : null, me);

        // Cells must exist early
        result?.refresh?.flush();

        return result;
    }

@matsbryntse matsbryntse added the regression Worked previously, now broken label Feb 4, 2025
@ExtAnimal ExtAnimal self-assigned this Feb 4, 2025
@ExtAnimal ExtAnimal added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Feb 4, 2025
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Feb 5, 2025
@isglass isglass added this to the 6.1.7 milestone Feb 5, 2025
@isglass isglass closed this as completed Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants