fix a bug of calculate_min_atomic_distance function #899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Function
calculate_min_atomic_distance
(#890 ) will not updatemin_n1
if all distances are larger thandist_sq
. So there may be a memory error for many systems when reading the -1th atomic symbol from arraycpu_atom_symbol
.Modification
Check
min_n1
before print and use macro to set the limit of minimum distanceOthers
I tested in$\mathrm{MoS_2}$ . This function may need more other tests.