Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Revisit GH Action scripts #319

Open
glsdown opened this issue May 16, 2023 · 0 comments
Open

[Enhancement] Revisit GH Action scripts #319

glsdown opened this issue May 16, 2023 · 0 comments
Labels
enhancement New feature or request quality of life A general improvement, that isn't a new feature or a bug

Comments

@glsdown
Copy link
Contributor

glsdown commented May 16, 2023

Documenting for future PRs because they aren't logically part of this fix

  1. The shell script chaining that happens in our workflow steps between getting the file changes and calling sqlfluff lint probably has to go. We've copied it all over the place from our project template and it's not very readable. I'm 90% sure it's been done better in a marketplace action that will save us lines of code
  2. More of a style thing. Do we want to combine the workflows into single yaml files based on which events trigger them. This is sort of how GitHub wants you to do it because then you can recycle the name of the status badges e.g."PR Workflows" would have job names "lint" and "test".

Point (1) I feel strongly about point (2) is a take it or leave it type thing but something we should at least look at. We choose between proliferation of yaml files or having long yaml files.

Originally posted by @dluftspring in #314 (review)

@glsdown glsdown changed the title Revisit GH Action scripts [Enhancement] Revisit GH Action scripts May 16, 2023
@glsdown glsdown added enhancement New feature or request quality of life A general improvement, that isn't a new feature or a bug labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality of life A general improvement, that isn't a new feature or a bug
Projects
None yet
Development

No branches or pull requests

1 participant